From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB57FC004C9 for ; Tue, 7 May 2019 11:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A45412054F for ; Tue, 7 May 2019 11:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725859AbfEGL05 (ORCPT ); Tue, 7 May 2019 07:26:57 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:45883 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbfEGL05 (ORCPT ); Tue, 7 May 2019 07:26:57 -0400 Received: by mail-ua1-f65.google.com with SMTP id o33so5853169uae.12; Tue, 07 May 2019 04:26:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzIbaBNYhvg73WNlQRNk3CzE4k84hRDE8fYSBPKxE40=; b=GVgN56dBDlnFf/BdrtJmS0ZJONzE+aycMAePNyliE70cc02SHz5+WVKTsQDtNDBi1I QL1daimOdvsoDh2xYNfrkvlMMS0OtBUAW0vW4OzakRmL9eWsrMXrZ/TXU1PCcrwxFuFd ELbdCvuiXLqsP1IItGQtc6DBTEDDOWdTq+10FU+uiBGDGYEP5wT4EtAMorQ288AGcyDQ SV+oGeVRTXu4kUT0hCVlDrv+OqTYwjB89o1nahIoTLXRDidn+s5cAjWNqvo1RJnV7LFA HMXY28B4jlk9JmqslG0Su8xXHP9/74t6woVvCsW7bFyjsAUvG/rbysY9NhhY5mU/+5pB /b7Q== X-Gm-Message-State: APjAAAVKAj8ZrX0q9g6Enx5HoRDoBL64aRMgXKeKnnVJT/JBiJXTdgzy H40auGKIu84AKquJuE0zQDjNSKSpq+bDGDwdL+4= X-Google-Smtp-Source: APXvYqxTyUhJ/Hdo8EsC8xxMOq+d9o8jfyQHdB8O8C1WedZ2N/j7SQlvc68hbfmmLxXJgjTyJEb3+QqWuoJvl2277Ws= X-Received: by 2002:ab0:1646:: with SMTP id l6mr437972uae.75.1557228415873; Tue, 07 May 2019 04:26:55 -0700 (PDT) MIME-Version: 1.0 References: <20190506234631.113226-1-chris.brandt@renesas.com> <20190506234631.113226-2-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 7 May 2019 13:26:44 +0200 Message-ID: Subject: Re: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris, On Tue, May 7, 2019 at 1:00 PM Chris Brandt wrote: > On Tue, May 07, 2019, Geert Uytterhoeven wrote: > > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1")) > > > + channel->uses_usb_x1 = true; > > > + > > > > Perhaps this can be checked some other way (e.g. by checking for a non- > > zero > > clock rate of the USB_X1 clock referenced from DT), thus removing the need > > for > > adding a custom property? > > Good point. I've done that for other drivers before and it worked well. > > I'll take this out...one less property to set :) > > Question: Since the driver depends on this, should I mention this in the > dt-bindings documentation ? Yes, this should be described in the section about the clocks property. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds