* [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712
@ 2023-03-31 14:14 Niklas Söderlund
2023-03-31 15:08 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Söderlund @ 2023-03-31 14:14 UTC (permalink / raw)
To: Geert Uytterhoeven, Rob Herring, Sakari Ailus, devicetree, linux-media
Cc: linux-renesas-soc, Niklas Söderlund
Specify the bus-type property for all three connected MAX96712.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
index e06b8eda85e1..dbc8dcab109d 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi
@@ -5,6 +5,8 @@
* Copyright (C) 2021 Glider bv
*/
+#include <dt-bindings/media/video-interfaces.h>
+
&csi40 {
status = "okay";
@@ -105,6 +107,7 @@ ports {
port@4 {
reg = <4>;
max96712_out0: endpoint {
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
clock-lanes = <0>;
data-lanes = <1 2 3 4>;
remote-endpoint = <&csi40_in>;
@@ -125,6 +128,7 @@ ports {
port@4 {
reg = <4>;
max96712_out1: endpoint {
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
clock-lanes = <0>;
data-lanes = <1 2 3 4>;
lane-polarities = <0 0 0 0 1>;
@@ -146,6 +150,7 @@ ports {
port@4 {
reg = <4>;
max96712_out2: endpoint {
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
clock-lanes = <0>;
data-lanes = <1 2 3 4>;
lane-polarities = <0 0 0 0 1>;
--
2.40.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712
2023-03-31 14:14 [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712 Niklas Söderlund
@ 2023-03-31 15:08 ` Geert Uytterhoeven
2023-03-31 15:30 ` Niklas Söderlund
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-03-31 15:08 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Rob Herring, Sakari Ailus, devicetree, linux-media, linux-renesas-soc
Hi Niklas,
Thanks for your patch!
On Fri, Mar 31, 2023 at 4:15 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Specify the bus-type property for all three connected MAX96712.
Probably this can use a little bit more explanation?
E.g. what does not work?
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Does this need a Fixes: tag?
Fixes: 283252132cb578cf ("arm64: dts: renesas: falcon-csi-dsi: Add and
connect MAX96712")
Note that a backport to v6.1 and earlier will depend on a backport of
commit f7eeb00845934851 ("media: dt-bindings: media: Add macros for
video interface bus types") in v6.2, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712
2023-03-31 15:08 ` Geert Uytterhoeven
@ 2023-03-31 15:30 ` Niklas Söderlund
2023-03-31 15:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Söderlund @ 2023-03-31 15:30 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Sakari Ailus, devicetree, linux-media, linux-renesas-soc
Hi Geert,
Thanks for your comments.
On 2023-03-31 17:08:50 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> Thanks for your patch!
>
> On Fri, Mar 31, 2023 at 4:15 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Specify the bus-type property for all three connected MAX96712.
>
> Probably this can use a little bit more explanation?
> E.g. what does not work?
Everything works both with and without this patch. This is done in
preparation to making the property mandatory. The default behavior when
parsing a node without this property is to default to D-PHY. So this is
just playing it safe and future prof tings as the default parsing comes
from the V4L2 core and not the driver itself.
>
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Does this need a Fixes: tag?
> Fixes: 283252132cb578cf ("arm64: dts: renesas: falcon-csi-dsi: Add and
> connect MAX96712")
>
> Note that a backport to v6.1 and earlier will depend on a backport of
> commit f7eeb00845934851 ("media: dt-bindings: media: Add macros for
> video interface bus types") in v6.2, too.
In a perfect word it would. But since the change is backward compatible
I'm not sure it's worth the effort given the dependency on the macro
definitions? If you think this is a good idea maybe a separate patch
posted for stable that uses the numerical values directly?
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712
2023-03-31 15:30 ` Niklas Söderlund
@ 2023-03-31 15:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-03-31 15:39 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Rob Herring, Sakari Ailus, devicetree, linux-media, linux-renesas-soc
Hi Niklas,
On Fri, Mar 31, 2023 at 5:30 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> On 2023-03-31 17:08:50 +0200, Geert Uytterhoeven wrote:
> > On Fri, Mar 31, 2023 at 4:15 PM Niklas Söderlund
> > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > > Specify the bus-type property for all three connected MAX96712.
> >
> > Probably this can use a little bit more explanation?
> > E.g. what does not work?
>
> Everything works both with and without this patch. This is done in
> preparation to making the property mandatory. The default behavior when
> parsing a node without this property is to default to D-PHY. So this is
> just playing it safe and future prof tings as the default parsing comes
> from the V4L2 core and not the driver itself.
OK. I realized most of that after reading your other patch...
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > LGTM, so
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Does this need a Fixes: tag?
> > Fixes: 283252132cb578cf ("arm64: dts: renesas: falcon-csi-dsi: Add and
> > connect MAX96712")
> >
> > Note that a backport to v6.1 and earlier will depend on a backport of
> > commit f7eeb00845934851 ("media: dt-bindings: media: Add macros for
> > video interface bus types") in v6.2, too.
>
> In a perfect word it would. But since the change is backward compatible
> I'm not sure it's worth the effort given the dependency on the macro
> definitions? If you think this is a good idea maybe a separate patch
> posted for stable that uses the numerical values directly?
OK, so no Fixes needed.
And if someone wants to backport it (renesas-bsp?), xe can backport the
latter, too (in fact renesas-bsp already did).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-31 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 14:14 [PATCH] arm64: dts: renesas: falcon-csi-dsi: Set bus-type for MAX96712 Niklas Söderlund
2023-03-31 15:08 ` Geert Uytterhoeven
2023-03-31 15:30 ` Niklas Söderlund
2023-03-31 15:39 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).