From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB9ECC4743C for ; Mon, 21 Jun 2021 11:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBCB3610C7 for ; Mon, 21 Jun 2021 11:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbhFUMA2 (ORCPT ); Mon, 21 Jun 2021 08:00:28 -0400 Received: from mail-vs1-f44.google.com ([209.85.217.44]:44580 "EHLO mail-vs1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhFUMA1 (ORCPT ); Mon, 21 Jun 2021 08:00:27 -0400 Received: by mail-vs1-f44.google.com with SMTP id x13so9047832vsf.11; Mon, 21 Jun 2021 04:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JvkNDTjahjImKj3duGEUeFWayKv7PwXaOqSSyc1OVNU=; b=mzK59I7nS2/Rbb7tHKJMj67tOfJ4UMw82PnXs9qpMeAYPi9OTasrlFXZsRv+kikZRN 1q00zKJKYkb4SZ335W2+vHhWXV5YeZktngy4xw8gJns7FeS36Bw+5V4gTyMw8r3VJiOK zfl7iWLEtT+BBtWNst4tpHJYQ1EO+6TwMp7E31DnM8RQUSLeB1R3QNgEw1bEih263m7x +bQL513hHSD+S8Z6iM/nbZS61pZKhh/4KSr4qQsHn0FU85FmL4ZzypKW4cKr/kcXYeIT b/4RJMiTvYpX3VlR4Qxr69LWo9Qyx2v135E4WtVQG9TUQFjKJRU6ob4wmaNaPGWcj9N5 thiA== X-Gm-Message-State: AOAM530qrcPEykzzwSoazQjg4+n8JPS4v8SFpODCeKv4XMcQdmCj3Y3Z v5XHiynpGPp7JAohPH1lrF7x5keWRKv+NbNlnTc= X-Google-Smtp-Source: ABdhPJyPTI7R1k+VHXKEn7V/ytUzb8Ph6jRLuMRm32wJsktBv6I/1V9kLSm+9ZXOI3OWa7GJ2hPARZleNFt36FNBlDA= X-Received: by 2002:a67:7787:: with SMTP id s129mr11610077vsc.40.1624276692898; Mon, 21 Jun 2021 04:58:12 -0700 (PDT) MIME-Version: 1.0 References: <20210408072402.15069-1-dinghao.liu@zju.edu.cn> In-Reply-To: <20210408072402.15069-1-dinghao.liu@zju.edu.cn> From: Geert Uytterhoeven Date: Mon, 21 Jun 2021 13:58:01 +0200 Message-ID: Subject: Re: [PATCH] PCI: rcar: Fix runtime PM imbalance in rcar_pcie_ep_probe To: Dinghao Liu Cc: Kangjie Lu , Marek Vasut , Yoshihiro Shimoda , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-pci , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Apr 8, 2021 at 9:24 AM Dinghao Liu wrote: > pm_runtime_get_sync() will increase the runtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM counter on error. > > Signed-off-by: Dinghao Liu Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds