Linux-Renesas-SoC Archive on lore.kernel.org
 help / Atom feed
* Re: [PATCH 3/4] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
       [not found] ` <1458148210-21800-4-git-send-email-ulrich.hecht+renesas@gmail.com>
@ 2019-01-10 15:38   ` Geert Uytterhoeven
  0 siblings, 0 replies; 1+ messages in thread
From: Geert Uytterhoeven @ 2019-01-10 15:38 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: Simon Horman, Linux-Renesas, open list:SERIAL DRIVERS, Magnus Damm

Hi Uli,

On Wed, Mar 16, 2016 at 6:10 PM Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Based on Rev. 1.00 of the R-Car H1 datasheet.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks for your patch!

A  few more comments below. Sorry for not noticing these issues
before.

This will be hard to test with remote access, as the normal console
cannot be rerouted to HSCIF, unlike on Bock-W.
Note that pfc-r8a7779.c lacks HSCIF pin groups and functions, so
these have to be added first, too.

> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi
> @@ -285,6 +285,32 @@
>                 status = "disabled";
>         };
>
> +       hscif0: serial@ffe48000 {
> +               compatible = "renesas,hscif-r8a7779",
> +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> +               reg = <0 0xffe48000 0 96>;

R-Car Gen1 does not use LPAE, hence #address-cells = <1> and
#size-cells are 1, not 2, so the zeroes must be dropped.

> +               interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>,
> +                        <&cpg_clocks R8A7779_CLK_S>,
> +                        <&scif_clk>;
> +               clock-names = "fck", "brg_int", "scif_clk";
> +               power-domains = <&cpg_clocks>;
> +               status = "disabled";
> +       };
> +
> +       hscif1: serial@ffe49000 {
> +               compatible = "renesas,hscif-r8a7779",
> +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> +               reg = <0 0xffe49000 0 96>;

Likewise.

> +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>,

R8A7779_CLK_HSCIF1

> +                        <&cpg_clocks R8A7779_CLK_S>,
> +                        <&scif_clk>;
> +               clock-names = "fck", "brg_int", "scif_clk";
> +               power-domains = <&cpg_clocks>;
> +               status = "disabled";
> +       };
> +
>         pfc: pfc@fffc0000 {
>                 compatible = "renesas,pfc-r8a7779";
>                 reg = <0xfffc0000 0x23c>;
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1458148210-21800-1-git-send-email-ulrich.hecht+renesas@gmail.com>
     [not found] ` <1458148210-21800-4-git-send-email-ulrich.hecht+renesas@gmail.com>
2019-01-10 15:38   ` [PATCH 3/4] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox