Re: [PATCH 3/4] ARM: dts: r8a7779: Add HSCIF0/1 device nodes

Re: [PATCH 3/4] ARM: dts: r8a7779: Add HSCIF0/1 device nodes

[Geert Uytterhoeven]

Hi Uli,

On Wed, Mar 16, 2016 at 6:10 PM Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Based on Rev. 1.00 of the R-Car H1 datasheet.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks for your patch!

A  few more comments below. Sorry for not noticing these issues
before.

This will be hard to test with remote access, as the normal console
cannot be rerouted to HSCIF, unlike on Bock-W.
Note that pfc-r8a7779.c lacks HSCIF pin groups and functions, so
these have to be added first, too.

> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi
> @@ -285,6 +285,32 @@
>                 status = "disabled";
>         };
>
> +       hscif0: serial@ffe48000 {
> +               compatible = "renesas,hscif-r8a7779",
> +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> +               reg = <0 0xffe48000 0 96>;

R-Car Gen1 does not use LPAE, hence #address-cells = <1> and
#size-cells are 1, not 2, so the zeroes must be dropped.

> +               interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>,
> +                        <&cpg_clocks R8A7779_CLK_S>,
> +                        <&scif_clk>;
> +               clock-names = "fck", "brg_int", "scif_clk";
> +               power-domains = <&cpg_clocks>;
> +               status = "disabled";
> +       };
> +
> +       hscif1: serial@ffe49000 {
> +               compatible = "renesas,hscif-r8a7779",
> +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> +               reg = <0 0xffe49000 0 96>;

Likewise.

> +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>,

R8A7779_CLK_HSCIF1

> +                        <&cpg_clocks R8A7779_CLK_S>,
> +                        <&scif_clk>;
> +               clock-names = "fck", "brg_int", "scif_clk";
> +               power-domains = <&cpg_clocks>;
> +               status = "disabled";
> +       };
> +
>         pfc: pfc@fffc0000 {
>                 compatible = "renesas,pfc-r8a7779";
>                 reg = <0xfffc0000 0x23c>;
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds