From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D64C43141 for ; Tue, 3 Dec 2019 20:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1B042084B for ; Tue, 3 Dec 2019 20:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727244AbfLCUkU (ORCPT ); Tue, 3 Dec 2019 15:40:20 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:33434 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727100AbfLCUkU (ORCPT ); Tue, 3 Dec 2019 15:40:20 -0500 Received: by mail-oi1-f194.google.com with SMTP id v140so4541089oie.0; Tue, 03 Dec 2019 12:40:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z349GRiHa+TYd/Gh6NHrqmK3aSP2393XNbqmu8AYhJY=; b=AilBBrDOyMlUU6jvLb9Mw9ki6ENn/AlYcE33SL8hT8Tjx7h0G6m8j2TuiIGXcw94VP vTag4lS5nsifVrJPd4b6fRVTSDQEiI8OIsFSmD7DYIoyCl9D0p+bLs0sPE+P/rSf8xFR DXKA00IoztrT6o3lwQMUQ0ywqR/GDNyQURukp2zuh+0XbudNF5+LGIFtzzRmrKugEWVD O39MUhADqbFoOoWmmSsQTGIXDv+VFF1ssXUG0HoYIM7vSjVGPNVBrQEXaMghDF4gMSj4 4muOeS0UVPPNjNfa3iT+tFp7Uclv1K/nv7sHTKipw1GmIZbGHW1+wjo0DjIGF51t8gXv 0a9A== X-Gm-Message-State: APjAAAVjGkkWE2eYbJ5Fv5kXPW3D9h/8jzRVnhz3/SYPCDlAAADTGGJR UYnPoqZIZwdXQcLS2MPxYAgnDvTVGnPt2sKCu7U= X-Google-Smtp-Source: APXvYqyZcXL4G/5uMj4Buh0JQMvj7ZbfYAwu5UGnu0/RiMZS4+NXQS7z9UEucye+2BDM1bUTmrDta6Qsm6i/225QPlk= X-Received: by 2002:aca:36c5:: with SMTP id d188mr5670131oia.54.1575405619309; Tue, 03 Dec 2019 12:40:19 -0800 (PST) MIME-Version: 1.0 References: <20191203034519.5640-1-chris.brandt@renesas.com> <20191203034519.5640-4-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 3 Dec 2019 21:40:08 +0100 Message-ID: Subject: Re: [PATCH 3/6] clk: renesas: r7s9210: Add SPIBSC clock To: Chris Brandt Cc: Mark Brown , Rob Herring , Mark Rutland , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , linux-spi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk , Mason Yang , Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris, On Tue, Dec 3, 2019 at 8:09 PM Chris Brandt wrote: > On Tue, Dec 3, 2019, Geert Uytterhoeven wrote: > > > +static const unsigned int r7s9210_crit_mod_clks[] __initconst = { > > > + MOD_CLK_ID_10(83), /* SPIBSC */ > > > > This is only a critical clock if XIP is in use, right? > > Correct. > > > > Can we do better, and only mark it critical if we detect the FLASH is used in > > XIP mode? > > E.g. by using for_each_compatible_node(..., "mtd-rom"), and checking if any > > of the corresponding register blocks matches the SPIBSC FLASH memory window? > > Well...technically...you don't need the "mtd-rom" partition when using the AXFS > file system. But, we can make a rule that you have to use it regardless. Just wondering, how does AXFS access the FLASH without it being mapped using "mtd-rom"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds