From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Alexander Graf <agraf@suse.de>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver
Date: Fri, 6 Sep 2019 13:09:39 +0200 [thread overview]
Message-ID: <CAMuHMdXOhrc1o5Jh3TN+JT4VFSSMg8Wy-rsgH=b8hNZQd8rXiA@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJUF1s1zyXVtoUGfbV7Yk+heua4rNjY=DrX=jr-v8UfNxA@mail.gmail.com>
On Tue, Jul 9, 2019 at 4:59 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> pon., 8 lip 2019 o 12:24 Geert Uytterhoeven <geert@linux-m68k.org> napisał(a):
> > On Mon, Jul 8, 2019 at 11:45 AM Bartosz Golaszewski
> > <bgolaszewski@baylibre.com> wrote:
> > > pt., 5 lip 2019 o 18:05 Geert Uytterhoeven <geert+renesas@glider.be> napisał(a):
> > > > +static int gpio_virt_agg_set_config(struct gpio_chip *chip,
> > > > + unsigned int offset, unsigned long config)
> > > > +{
> > > > + struct gpio_virt_agg_priv *priv = gpiochip_get_data(chip);
> > > > +
> > > > + chip = priv->desc[offset]->gdev->chip;
> > > > + if (chip->set_config)
> > > > + return chip->set_config(chip, offset, config);
> > > > +
> > > > + // FIXME gpiod_set_transitory() expects success if not implemented
> >
> > BTW, do you have a comment about this FIXME?
>
> Ha! Interesting. I'll give it a thought and respond elsewhere as it's
> a different subject.
>
> > > > + return -ENOTSUPP;
Upon closer look, this turns out to be a red herring: gpiod_set_transitory()
converts -ENOTSUPP to zero, so there is no issue.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-09-06 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:05 [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver Geert Uytterhoeven
2019-07-08 9:44 ` Bartosz Golaszewski
2019-07-08 10:24 ` Geert Uytterhoeven
2019-07-09 14:58 ` Bartosz Golaszewski
2019-07-09 15:59 ` Geert Uytterhoeven
2019-07-12 9:27 ` Bartosz Golaszewski
2019-09-06 11:14 ` Geert Uytterhoeven
2019-09-06 11:09 ` Geert Uytterhoeven [this message]
2019-07-10 2:00 ` Phil Reid
2019-07-10 10:21 ` Geert Uytterhoeven
2019-07-11 9:24 ` Phil Reid
2019-07-11 9:54 ` Geert Uytterhoeven
2019-08-01 8:41 ` Linus Walleij
2019-08-05 10:21 ` Marc Zyngier
2019-08-05 10:56 ` Linus Walleij
2019-09-12 8:56 ` Linus Walleij
2019-09-12 8:59 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXOhrc1o5Jh3TN+JT4VFSSMg8Wy-rsgH=b8hNZQd8rXiA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=agraf@suse.de \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).