From: Geert Uytterhoeven <geert@linux-m68k.org> To: Chris Brandt <chris.brandt@renesas.com> Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-spi <linux-spi@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, Mason Yang <masonccyang@mxic.com.tw>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Subject: Re: [PATCH 2/6] ARM: dts: r7s72100: Add SPIBSC clocks Date: Tue, 3 Dec 2019 19:42:49 +0100 Message-ID: <CAMuHMdXUVdG_PMQEpz=QWLCaabfK8Mc41zFiymXJ4Rx_C2gzdg@mail.gmail.com> (raw) In-Reply-To: <20191203034519.5640-3-chris.brandt@renesas.com> Hi Chris, On Tue, Dec 3, 2019 at 4:46 AM Chris Brandt <chris.brandt@renesas.com> wrote: > The SPIBSC-0 clock is marked as critical because for XIP systems, this > is the SPI flash controller it will boot from and the kernel will also > be running from so it cannot be turned off. > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> Thanks for your patch! > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -101,6 +101,26 @@ > #size-cells = <1>; > ranges; > > + spibsc0: spi@3fefa000 { > + compatible = "renesas,r7s72100-spibsc", "renesas,spibsc"; > + reg = <0x3fefa000 0x100>, <0x18000000 0x4000000>; The second region conflicts with the XIP flash@18000000 in arch/arm/boot/dts/r7s72100-gr-peach.dts. Yes, I know it is the same device ;-) > + clocks = <&mstp9_clks R7S72100_CLK_SPIBSC0>; > + power-domains = <&cpg_clocks>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + spibsc1: spi@3fefb000 { > + compatible = "renesas,r7s72100-spibsc", "renesas,spibsc"; > + reg = <0x3fefb000 0x100>, <0x1c000000 0x4000000>; > + clocks = <&mstp9_clks R7S72100_CLK_SPIBSC1>; > + power-domains = <&cpg_clocks>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > L2: cache-controller@3ffff000 { > compatible = "arm,pl310-cache"; > reg = <0x3ffff000 0x1000>; > @@ -467,11 +487,13 @@ > #clock-cells = <1>; > compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0xfcfe0438 4>; > - clocks = <&p0_clk>, <&p0_clk>, <&p0_clk>, <&p0_clk>; > + clocks = <&p0_clk>, <&p0_clk>, <&p0_clk>, <&p0_clk>, <&b_clk>, <&b_clk>; > clock-indices = < > R7S72100_CLK_I2C0 R7S72100_CLK_I2C1 R7S72100_CLK_I2C2 R7S72100_CLK_I2C3 > + R7S72100_CLK_SPIBSC0 R7S72100_CLK_SPIBSC1 > >; > - clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3"; > + clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3", "spibsc0", "spibsc1"; > + clock-critical = <4>; /* spibsc0 */ Iff we go this clock-critical route, I think this should be specified in the board-specific .dts instead of in the SoC-specific .dtsi. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply index Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 3:45 [PATCH 0/6] spi: Add Renesas SPIBSC controller Chris Brandt 2019-12-03 3:45 ` [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support Chris Brandt 2019-12-03 18:32 ` Geert Uytterhoeven 2019-12-03 18:46 ` Chris Brandt 2019-12-03 18:51 ` Geert Uytterhoeven 2019-12-03 3:45 ` [PATCH 2/6] ARM: dts: r7s72100: Add SPIBSC clocks Chris Brandt 2019-12-03 18:42 ` Geert Uytterhoeven [this message] 2019-12-03 18:57 ` Chris Brandt 2019-12-03 19:12 ` Geert Uytterhoeven 2019-12-04 8:38 ` Lee Jones 2019-12-04 9:03 ` Geert Uytterhoeven 2019-12-04 9:47 ` Lee Jones 2019-12-04 11:00 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 3/6] clk: renesas: r7s9210: Add SPIBSC clock Chris Brandt 2019-12-03 18:49 ` Geert Uytterhoeven 2019-12-03 19:09 ` Chris Brandt 2019-12-03 20:40 ` Geert Uytterhoeven 2019-12-04 3:09 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 4/6] spi: Add SPIBSC driver Chris Brandt 2019-12-03 14:19 ` Mark Brown 2019-12-03 15:00 ` Chris Brandt 2019-12-03 18:29 ` Geert Uytterhoeven 2019-12-04 11:25 ` Mark Brown 2019-12-04 12:14 ` Geert Uytterhoeven 2019-12-04 15:51 ` Chris Brandt 2019-12-04 16:49 ` Mark Brown 2019-12-03 18:28 ` Geert Uytterhoeven 2019-12-04 11:18 ` Mark Brown 2019-12-04 22:12 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 5/6] ARM: dts: r7s9210: Add SPIBSC Device support Chris Brandt 2019-12-03 18:59 ` Geert Uytterhoeven 2019-12-03 22:38 ` Chris Brandt 2019-12-04 7:57 ` Geert Uytterhoeven 2019-12-04 11:04 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 6/6] dt-bindings: spi: Document Renesas SPIBSC bindings Chris Brandt 2019-12-03 9:14 ` Sergei Shtylyov 2019-12-03 13:27 ` Chris Brandt 2019-12-03 16:04 ` Sergei Shtylyov 2019-12-03 16:35 ` Chris Brandt 2019-12-03 18:57 ` Geert Uytterhoeven 2019-12-03 20:39 ` Geert Uytterhoeven 2019-12-04 2:54 ` Chris Brandt 2019-12-04 8:56 ` Geert Uytterhoeven 2019-12-04 13:31 ` Chris Brandt 2019-12-05 15:48 ` Geert Uytterhoeven 2019-12-05 16:00 ` Chris Brandt 2019-12-04 8:40 ` Geert Uytterhoeven 2019-12-03 22:33 ` Chris Brandt 2019-12-04 8:43 ` Geert Uytterhoeven 2019-12-04 11:19 ` Chris Brandt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdXUVdG_PMQEpz=QWLCaabfK8Mc41zFiymXJ4Rx_C2gzdg@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=broonie@kernel.org \ --cc=chris.brandt@renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=linux-clk@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=masonccyang@mxic.com.tw \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Renesas-SoC Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \ linux-renesas-soc@vger.kernel.org public-inbox-index linux-renesas-soc Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc AGPL code for this site: git clone https://public-inbox.org/public-inbox.git