From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFC6C10DCE for ; Thu, 12 Mar 2020 13:38:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C29B2206E7 for ; Thu, 12 Mar 2020 13:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbgCLNii (ORCPT ); Thu, 12 Mar 2020 09:38:38 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:37358 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727194AbgCLNii (ORCPT ); Thu, 12 Mar 2020 09:38:38 -0400 Received: by mail-ot1-f66.google.com with SMTP id i12so949534otp.4; Thu, 12 Mar 2020 06:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LZj5cPIDRAd/O2vyQ2odALBxqPsyj21il1eEEBudhSo=; b=ShU8dPnNiYXDf/bWDjNuLmbrWw3Wn8PJusBaeQkkylqUCegHyNeUs1KBROFHALggDh 2w1hQ6o39GBz8+4pkNltI7wix57d/cX92VPgI9u+dY544j7z5yOe3dL7EgWTm0k7f6ui ycMA4gyHyVxob57Z0s2m7el9yCN7ceacixz10qpxk1gttstkP4ecNSTym7hJrvqsSXqO uUqxCrLG7IqG6gNRimx57RgpVuKAVT4cWe6+nHL73MJBIeJM1j2twjhhw8UE/uyjn9qW AZ0x6+2evAYGmSIkCBCqTHwdDr8W6mrWSnZ2ZFAv8Blb87jB+RT0fjmbtujtd9jgGlQJ 4e2A== X-Gm-Message-State: ANhLgQ3QOAOtjY8tTPGOAwUpnD6vHIjDIpvecaUSKkojVMtbq90ZgpbZ UVH47OcjgH/vTCklqO5RAeJbDzAtVB6IhEMHG0Y= X-Google-Smtp-Source: ADFU+vuSh/99ve5kjxmesXn1EBGQ7zk1qjQDub4hZ/WAGoOsllXKp5oQsA09B8Mo6NZKe90UItuDR7/YvIxeTZ9xMXs= X-Received: by 2002:a4a:e211:: with SMTP id b17mr4052099oot.79.1584020315784; Thu, 12 Mar 2020 06:38:35 -0700 (PDT) MIME-Version: 1.0 References: <20200312133244.9564-1-wsa@the-dreams.de> In-Reply-To: <20200312133244.9564-1-wsa@the-dreams.de> From: Geert Uytterhoeven Date: Thu, 12 Mar 2020 14:38:24 +0100 Message-ID: Subject: Re: [RFC PATCH] i2c: acpi: put device when verifying client fails To: Wolfram Sang Cc: Linux I2C , ACPI Devel Maling List , Linux-Renesas , Mika Westerberg , Andy Shevchenko , Jarkko Nikula , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Mar 12, 2020 at 2:32 PM Wolfram Sang wrote: > From: Wolfram Sang > > i2c_verify_client() can fail, so we need to put the device when that > happens. > > Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications") > Reported-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds