From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FD2C33C99 for ; Tue, 7 Jan 2020 09:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF649206DB for ; Tue, 7 Jan 2020 09:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbgAGJyC (ORCPT ); Tue, 7 Jan 2020 04:54:02 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:44266 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgAGJyC (ORCPT ); Tue, 7 Jan 2020 04:54:02 -0500 Received: by mail-ot1-f65.google.com with SMTP id h9so73097977otj.11; Tue, 07 Jan 2020 01:54:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s/kMF/bJ1LDeS7SpyIbqm4OFqc7vZ2oyDMR/GikRQIw=; b=QNA+eFE72GrsOPHyI40Xztm3c2n4U1a7cNQAKoqcp1Em9qPeYMt9Wp5QjJ8rtz34f9 9I660F4JJn+3kVEAMwkmu8hm7K/4Tai9hO1IP2n6QAHCNmIA4W1ISlXoKPkgQ6PZ6Pax ccH51MuCFYsRsp987DlENGLKJcLUOwz7slknt2I+DiY6ZaMdYjgHq+113PfiYIUMWUv7 ZcQIN/Y8dw38YSM87dQ4ypv54SQhYzzWNSWJChMMWe7zn2mhwqV2sqrAILfO8mhGaX/A ekyfc0Yfo2HvQaXQ7zH3QgFzPrE67nZBKLAOSkOR2sXbN64WUcb7bJYxYxTKJ1iUlKzB TUSw== X-Gm-Message-State: APjAAAXtkPUpwAtr4zXhMc3ZJFzMPj7CczpiS1+Vr5DsMkwPeZfMvx94 376W6jyTW4NyCEB03WGdHHbvxljRqaQe9k0xu4pjTxMh X-Google-Smtp-Source: APXvYqw+QsF3UKmg3Vi8I2d1cNzaVtGjgunAa52mgg6hD2hLvZCebPx8bMgoN7esxIepasZ1i391EWiUVVyZBaCx2+s= X-Received: by 2002:a9d:dc1:: with SMTP id 59mr21737883ots.250.1578390841476; Tue, 07 Jan 2020 01:54:01 -0800 (PST) MIME-Version: 1.0 References: <20191231161400.1688-1-wsa+renesas@sang-engineering.com> <20191231161400.1688-2-wsa+renesas@sang-engineering.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 7 Jan 2020 10:53:50 +0100 Message-ID: Subject: Re: [RFC PATCH 1/5] i2c: core: refactor scanning for a client To: Kieran Bingham Cc: Wolfram Sang , Linux I2C , Linux-Renesas , Luca Ceresoli , Jacopo Mondi , Laurent Pinchart , Vladimir Zapolskiy Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Kieran, On Tue, Jan 7, 2020 at 10:26 AM Kieran Bingham wrote: > This looks reasonable to me, I see Laurent has a concern over the use of > a WARN to present a backtrace, but I think in this instance it will be > useful as it will facilitate identifying what code path provided the > incorrect address. Quoting GregKH: | We really do not want WARN_ON() anywhere, as that causes systems with | panic-on-warn to reboot. https://lore.kernel.org/lkml/20191121135743.GA552517@kroah.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds