From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH/RFC 1/2] ARM: dts: r8a7778: Correct internal delay for i2c[123]
Date: Wed, 5 May 2021 09:41:24 +0200 [thread overview]
Message-ID: <CAMuHMdXWQ0CR0QpYeVJ9TWTUf8M7K=QZ+5z4-JTJgutq_ndBng@mail.gmail.com> (raw)
In-Reply-To: <20210505071323.GA1009@ninjato>
Hi Wolfram,
On Wed, May 5, 2021 at 9:13 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Tue, May 04, 2021 at 04:41:24PM +0200, Geert Uytterhoeven wrote:
> > According to the R-Car M1A Hardware User's Manual Rev. 1.00, the LSI
> > internal delay for I2C instances 1 to 3 is 5 ns (typ.), which differs
> > from the default 50 ns as specified for instance 0.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I wonder if we shouldn't also specify the 50ns for IIC0 because it is
> describing the HW instead of relying on the Linux-only default value in
> the driver? Other than that:
With the json-schema bindings, we do have:
+ i2c-scl-internal-delay-ns:
+ default: 50
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-05-05 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:41 [PATCH/RFC 0/2] ARM: dts: rcar-gen1: Correct internal delay for i2c[123] Geert Uytterhoeven
2021-05-04 14:41 ` [PATCH/RFC 1/2] ARM: dts: r8a7778: " Geert Uytterhoeven
2021-05-05 7:13 ` Wolfram Sang
2021-05-05 7:41 ` Geert Uytterhoeven [this message]
2021-05-04 14:41 ` [PATCH/RFC 2/2] ARM: dts: r8a7779: " Geert Uytterhoeven
2021-05-05 7:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXWQ0CR0QpYeVJ9TWTUf8M7K=QZ+5z4-JTJgutq_ndBng@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).