From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E9EC2D0E2 for ; Wed, 23 Sep 2020 13:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD259221EB for ; Wed, 23 Sep 2020 13:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgIWNdi convert rfc822-to-8bit (ORCPT ); Wed, 23 Sep 2020 09:33:38 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:32907 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIWNdi (ORCPT ); Wed, 23 Sep 2020 09:33:38 -0400 Received: by mail-oi1-f196.google.com with SMTP id m7so25057616oie.0; Wed, 23 Sep 2020 06:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jLvhxV8WN8tYwAsKLuQ5qoca0AxXLmY9ncmfD688UVE=; b=QsOT76/UlfNd6ehu92bgbyqo/n547aOOepxdTR6Z06939gAY+FLNAb3R5FEcUdN+je saiCP8jJHSe5HtdUXiGFzquR0tTo4+ulzI9x05+ZZIeqF6iUEO8wPlh4yXWRyFxmmQD8 dOiQDvX5AoBEH1vSFS4nOdBP/u2wsg67E/f1UDSSBuKmdORlujLLRZfTxs7r3ADED0r5 +48fM1uQW7lxiuLwSlqW4Q1J7HRN62vgXxArGJ40jYRx+kKyA5IHfAP1nbfoRNctnPvY 9IBXuXpiwVTxJhVGpK9Shi+c4WUty9BljOnWODVGKfCKBjJigzh89rV8VFX+qTEKWhRW w1WA== X-Gm-Message-State: AOAM533VSOa+nuMR2z4KeJY89VrrBSUr+PIZ41exm5Fy0zFmhk6MFSWG 7B8cDhpqJDDbhBfC9afKjx2yBwB0T6efa4XpAsxI30Xthj8= X-Google-Smtp-Source: ABdhPJxf5OeqXwmXtbr0WhpaUjkbIzjraQ7D8svwIUi3MJOGi3XetHfwKcml4BiolSeLliTWBCZ7aTJUY0J3J6a7hUw= X-Received: by 2002:aca:4441:: with SMTP id r62mr5414688oia.153.1600868017348; Wed, 23 Sep 2020 06:33:37 -0700 (PDT) MIME-Version: 1.0 References: <20200916105949.24858-1-fabrizio.castro.jz@renesas.com> <20200916105949.24858-3-fabrizio.castro.jz@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 23 Sep 2020 15:33:26 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema To: Fabrizio Castro Cc: Mauro Carvalho Chehab , Rob Herring , Ramesh Shanmugasundaram , Linux Media Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , Laurent Pinchart Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro wrote: > > From: Geert Uytterhoeven > > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro > > wrote: > > > Convert the Renesas DRIF bindings to DT schema and update > > > MAINTAINERS accordingly. > > > > > > Signed-off-by: Fabrizio Castro > > > +if: > > > + required: > > > + - renesas,primary-bond > > > +then: > > > + required: > > > + - pinctrl-0 > > > + - pinctrl-names > > > + - port > > > > The last 3 properties must not be present for a secondary interface, > > right? > > If you have both channels enabled, then one of the two has to define properties: > * renesas,primary-bond, pinctrl-0, pinctrl-names, and port. > > If only one channel is enabled, then the primary bond concept loses its value, > whether renesas,primary-bond is specified or not doesn’t matter anymore, but the > enabled node has to specify the pinctrl related properties and the port. > > > To express that, I think you need to add: > > > > else: > > properties: > > - pinctrl-0: false > > - pinctrl-names: false > > - port: false > > If I went with this, we would not be able to allow those properties to be specified in the > only enabled node for single channels configurations. > > Is there a better way to approach this? > > I'll wait for this point to get sorted before sending v3 out. The old binding said: -Required properties of an internal channel when: - - It is the only enabled channel of the bond (or) - - If it acts as primary among enabled bonds -- renesas,primary-bond: empty property indicating the channel acts as primary - among the bonded channels. so renesas,primary-bond is required for the only enabled node for single channels configurations anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds