From: Ulf Hansson <ulf.hansson@linaro.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: core: retry CMD1 in mmc_send_op_cond() even if the ocr = 0
Date: Mon, 29 Apr 2019 12:44:35 +0200 [thread overview]
Message-ID: <CAPDyKFpKw84x6+gTrQoAavkF4uVURxsTZ6zK1S9r08+HF_HNkg@mail.gmail.com> (raw)
In-Reply-To: <1554807906-9704-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
On Tue, 9 Apr 2019 at 13:09, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>
> According to eMMC specification v5.1 section 6.4.3, we should issue
> CMD1 repeatedly in the idle state until the eMMC is ready even if
> the mmc_attach_mmc() calls this function with ocr = 0. Otherwise
> some eMMC devices seems to enter the inactive mode after
> mmc_init_card() issued CMD0 when the eMMC device is busy.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Applied for next, thanks!
Let's get some test coverage of this before we decide if this a
material for stable.
Kind regards
Uffe
> ---
> Changes from v1 (https://patchwork.kernel.org/patch/10874619/):
> - Revise the comment on the source code.
>
> We can reproduce this issue if:
> - we add no-sd and no-sdio property into sdhi2 node of salvator-common.dtsi,
> - the renesas_sdhi driver is kernel module,
> - Using a Salvator-XS board that has Samsung eMMC device,
> - enter suspend and exit it,
> - and then insmod renesas_sdhi_{core,internal_dmac}.ko.
>
> After that, the following error happened and any partitions are not detected.
> mmc1: error -110 whilst initialising MMC card
>
> I tested this patch on:
> - M3-N Salvator-XS with a Samsung eMMC device,
> - M3-W Salvator-X with SiliconMotion eMMC device,
> - and M3-W Starter Kit with Micron eMMC device.
>
> drivers/mmc/core/mmc_ops.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index c5208fb..a533cab 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -184,11 +184,7 @@ int mmc_send_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
> if (err)
> break;
>
> - /* if we're just probing, do a single pass */
> - if (ocr == 0)
> - break;
> -
> - /* otherwise wait until reset completes */
> + /* wait until reset completes */
> if (mmc_host_is_spi(host)) {
> if (!(cmd.resp[0] & R1_SPI_IDLE))
> break;
> @@ -200,6 +196,16 @@ int mmc_send_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
> err = -ETIMEDOUT;
>
> mmc_delay(10);
> +
> + /*
> + * According to eMMC specification v5.1 section 6.4.3, we
> + * should issue CMD1 repeatedly in the idle state until
> + * the eMMC is ready. Otherwise some eMMC devices seem to enter
> + * the inactive mode after mmc_init_card() issued CMD0 when
> + * the eMMC device is busy.
> + */
> + if (!ocr && !mmc_host_is_spi(host))
> + cmd.arg = cmd.resp[0] | BIT(30);
> }
>
> if (rocr && !mmc_host_is_spi(host))
> --
> 2.7.4
>
prev parent reply other threads:[~2019-04-29 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:05 [PATCH v2] mmc: core: retry CMD1 in mmc_send_op_cond() even if the ocr = 0 Yoshihiro Shimoda
2019-04-18 6:45 ` Wolfram Sang
2019-04-29 10:44 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpKw84x6+gTrQoAavkF4uVURxsTZ6zK1S9r08+HF_HNkg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).