From: Ulf Hansson <ulf.hansson@linaro.org>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Takeshi Saito" <takeshi.saito.xv@renesas.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Simon Horman" <horms+renesas@verge.net.au>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] mmc: renesas_sdhi: Fix card initialization failure in high speed mode
Date: Tue, 29 Jan 2019 09:05:41 +0100 [thread overview]
Message-ID: <CAPDyKFpa=q+oSES115SBUnpFVq+nUGwH7sY5F=go4-rZp6EasQ@mail.gmail.com> (raw)
In-Reply-To: <20190129054039.15278-1-marek.vasut@gmail.com>
On Tue, 29 Jan 2019 at 06:40, <marek.vasut@gmail.com> wrote:
>
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> This fixes card initialization failure in high speed mode.
>
> If U-Boot uses SDR or HS200/400 mode before starting Linux and Linux
> DT does not enable SDR/HS200/HS400 mode, card initialization fails in
> high speed mode.
>
> It is necessary to initialize SCC registers during card initialization
> phase. HW reset function is registered only for a port with either of
> SDR/HS200/HS400 properties in device tree. If SDR/HS200/HS400 properties
> are not present in device tree, SCC registers will not be reset. In SoC
> that support SCC registers, HW reset function should be registered
> regardless of the configuration of device tree.
>
> Reproduction procedure:
> - Use U-Boot that support MMC HS200/400 mode.
> - Delete HS200/HS400 properties in device tree.
> (Delete mmc-hs200-1_8v and mmc-hs400-1_8v)
> - MMC port works high speed mode and all commands fail.
>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-mmc@vger.kernel.org
Is this a regression? Should it be tagged for stable?
Kind regards
Uffe
> --
> NOTE: Marek: - Reworded commit message
> - Updated patch to next/master
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 31a351a20dc0..7e2a75c4f36f 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -723,6 +723,13 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> host->ops.start_signal_voltage_switch =
> renesas_sdhi_start_signal_voltage_switch;
> host->sdcard_irq_setbit_mask = TMIO_STAT_ALWAYS_SET_27;
> +
> + /* SDR and HS200/400 registers requires HW reset */
> + if (of_data && of_data->scc_offset) {
> + priv->scc_ctl = host->ctl + of_data->scc_offset;
> + host->mmc->caps |= MMC_CAP_HW_RESET;
> + host->hw_reset = renesas_sdhi_hw_reset;
> + }
> }
>
> /* Orginally registers were 16 bit apart, could be 32 or 64 nowadays */
> @@ -775,8 +782,6 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> const struct renesas_sdhi_scc *taps = of_data->taps;
> bool hit = false;
>
> - host->mmc->caps |= MMC_CAP_HW_RESET;
> -
> for (i = 0; i < of_data->taps_num; i++) {
> if (taps[i].clk_rate == 0 ||
> taps[i].clk_rate == host->mmc->f_max) {
> @@ -789,12 +794,10 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> if (!hit)
> dev_warn(&host->pdev->dev, "Unknown clock rate for SDR104\n");
>
> - priv->scc_ctl = host->ctl + of_data->scc_offset;
> host->init_tuning = renesas_sdhi_init_tuning;
> host->prepare_tuning = renesas_sdhi_prepare_tuning;
> host->select_tuning = renesas_sdhi_select_tuning;
> host->check_scc_error = renesas_sdhi_check_scc_error;
> - host->hw_reset = renesas_sdhi_hw_reset;
> host->prepare_hs400_tuning =
> renesas_sdhi_prepare_hs400_tuning;
> host->hs400_downgrade = renesas_sdhi_disable_scc;
> --
> 2.19.2
>
next prev parent reply other threads:[~2019-01-29 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 5:40 [PATCH] mmc: renesas_sdhi: Fix card initialization failure in high speed mode marek.vasut
2019-01-29 8:01 ` Wolfram Sang
2019-01-29 8:05 ` Ulf Hansson [this message]
2019-01-29 9:56 ` Marek Vasut
2019-01-29 16:31 ` Wolfram Sang
2019-01-30 9:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpa=q+oSES115SBUnpFVq+nUGwH7sY5F=go4-rZp6EasQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=takeshi.saito.xv@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).