From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7C8CCA47F for ; Tue, 19 Jul 2022 10:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbiGSKsU (ORCPT ); Tue, 19 Jul 2022 06:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236922AbiGSKsS (ORCPT ); Tue, 19 Jul 2022 06:48:18 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 819D3371B9 for ; Tue, 19 Jul 2022 03:48:16 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id e15so19031885edj.2 for ; Tue, 19 Jul 2022 03:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jAJckkD4UuuHl70O8qDgCKBp28ZgCMKEQEQG2B3UfE0=; b=Q/Szb78YeaaPFs6XH9/IQHBVYt7poFICWO1a+McjynpiY6pG9I1QRhvcjCyZW6vxnT PxrDVy8fqimCTQDCY5vw60fGcwvARB/d+GrfnEURIYrjlYUAu+g4KEelBSEVAkLTon1i BraWKs6Eih7MiBHZXskxv4ylpEKf9Zme+IDLlu/1kv4oyrljN1MqwRfNIWViVXUNrct2 u7AiHcXjfoR3SpMsm7PwS6mcOZXhMToPiIVophvCrx4VBf1kYpn4hXZYAEWApydD4tre eQIVXISQIy7ixmTDgFI3pw5O25NGhwF2bp3seoOr71PWiE9pToJ9D/iKflX4V3b20TqG hV0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jAJckkD4UuuHl70O8qDgCKBp28ZgCMKEQEQG2B3UfE0=; b=Crf2tFpQdv36OLcJ3xIbr25BRn71B8yzdHfm/g+fg33mqcVe2YrFTvtFN+6cvvBzAO 3cfdMclnR8QW0IjB57xddx+64QXT71hxRAUXxga9s4G90SXwJT3fzkmvcZ6dnhUuLhHU zVjQvBHRC5VEdq+3hEK3PMNTaZRerbq24NEZdFcEbcDgYzh+yEHW80XyO03NFuK/mwKJ kTyyyj06t5lRd6b56RpV2rDryFe/CARDoRhFbgdJAzKPlAjrUNwHc5XeTnf0PkPQ8T40 cUtAFHpSmn8tJ455rNZJvaDUDR8LjcGYPUNd81PVYzOs9wdBjhjWidjmfesReT2CJd2I nGsw== X-Gm-Message-State: AJIora/hKkCJaOXLLmQqwJpbq+rnF9JautItwJ2C+RKeBWxMOmrz9zyK Sb4mJYmU5s/I9XZZM0S02Ujj5Jl6kIsOf/UGOHCj6A== X-Google-Smtp-Source: AGRyM1ua9YfZzMzY+4okMS9alFUwqOoJ7z9AWWeCobrYmvatBAnyqrolqInpc2mJusYtBC/LbNwM0xE6plFTLrpI0iA= X-Received: by 2002:a05:6402:4490:b0:43a:8f5a:d273 with SMTP id er16-20020a056402449000b0043a8f5ad273mr42301746edb.6.1658227695061; Tue, 19 Jul 2022 03:48:15 -0700 (PDT) MIME-Version: 1.0 References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-5-sam@ravnborg.org> In-Reply-To: From: Dave Stevenson Date: Tue, 19 Jul 2022 11:47:58 +0100 Message-ID: Subject: Re: [PATCH v1 12/12] drm/todo: Add bridge related todo items To: Sam Ravnborg Cc: Dafna Hirschfeld , Neil Armstrong , David Airlie , Tomi Valkeinen , DRI Development , Laurent Pinchart , Andrzej Hajda , Guenter Roeck , chrome-platform@lists.linux.dev, Jernej Skrabec , Chun-Kuang Hu , Jitao Shi , Arnd Bergmann , Jonas Karlman , linux-mediatek@lists.infradead.org, Matthias Brugger , Linux ARM , Philip Chen , Robert Foss , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Thomas Zimmermann , Enric Balletbo i Serra , Cai Huoqing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Sam On Mon, 18 Jul 2022 at 19:00, Sam Ravnborg wrote: > > Hi Dave, > > On Mon, Jul 18, 2022 at 11:27:37AM +0100, Dave Stevenson wrote: > > Hi Sam > > > > On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg wrote: > > > > > > Add todo in the hope someone will help updating the bridge drivers. > > > > > > v2: > > > - Updated descriptions in todo.rst > > > > > > Signed-off-by: Sam Ravnborg > > > Acked-by: Maxime Ripard > > > Cc: Laurent Pinchart > > > Cc: Maarten Lankhorst > > > Cc: Maxime Ripard > > > Cc: Thomas Zimmermann > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > --- > > > Documentation/gpu/todo.rst | 20 ++++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > > index 10bfb50908d1..fbcc232e0bc1 100644 > > > --- a/Documentation/gpu/todo.rst > > > +++ b/Documentation/gpu/todo.rst > > > @@ -480,6 +480,26 @@ Contact: Thomas Zimmermann > > > > > > Level: Starter > > > > > > +Drop use of deprecated operations in bridge drivers > > > +-------------------------------------------------- > > > + > > > +&struct drm_bridge_funcs contains a number of deprecated operations > > > +which can be replaced by the atomic variants. > > > + > > > +The following is more or less 1:1 replacements with the arguments > > > +and names adjusted: > > > +* pre_enable => atomic_pre_enable > > > +* enable => atomic_enable > > > +* disable => atomic_disable > > > +* post_disable => atomic_post_disable > > > + > > > +* mode_set is no longer required and the implementation shall be merged > > > + with atomic_enable. > > > > The dw-mipi-dsi and msm DSI host controller bridge drivers are > > currently relying on mode_set as a convenient hook to power up the DSI > > host prior to pre_enable of the bridge chain. Removing it is therefore > > going to break those. > > > > There is a proposed mechanism to allow for the removal of this hack > > [1], but it's still waiting on R-B tags and/or discussion from bridge > > maintainers (gentle nudge as you are one of those maintainers). > > I have over time gained some knowledge of how bridges works and have > applied a few patches - but the maintainer role belongs to others. > I just try to help a bit. Apologies, I'd misread the text in this patch +Contact: bridge maintainers, Sam Ravnborg , + Laurent Pinchart as being that you and Laurent were the bridge maintainers. Colon instead of comma :-/ > I will review the referenced series - could you then in return > review this series? Sure, these look to be within my levels of knowledge. > > > > And do you mean merge with atomic_enable, or merge with > > atomic_pre_enable? atomic_pre_enable would be more applicable for > > almost all the bridges I'm aware of as they want to be configured > > before video starts. > Thanks, yes you are right. I will update the text to refer to > pre_enable as this is often the right choice. Looking at how many > bridges who implements mode_set, or are not yet atomic, this will > take a while before we can drop it. Thanks. That makes more logical sense to me for the majority of cases. As to timescales, it always takes longer than ideal to migrate older drivers. Thanks Dave