From: Biju Das <biju.das.jz@bp.renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Sergey Shtylyov <s.shtylyov@omprussia.ru>,
Adam Ford <aford173@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Yuusuke Ashizuka <ashiduka@fujitsu.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH net-next v2 3/8] ravb: Add num_gstat_queue to struct ravb_hw_info
Date: Tue, 3 Aug 2021 19:47:23 +0000 [thread overview]
Message-ID: <OS0PR01MB59220F188237ADB3BBFDBD5186F09@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <f5695fbd-f365-c86e-3ca2-41cf59ad8354@gmail.com>
Hi Sergei,
> Subject: Re: [PATCH net-next v2 3/8] ravb: Add num_gstat_queue to struct
> ravb_hw_info
>
> On 8/3/21 10:13 PM, Biju Das wrote:
>
> [...]
> >>> The number of queues used in retrieving device stats for R-Car is 2,
> >>> whereas for RZ/G2L it is 1.
> >
> >>
> >> Mhm, how many RX queues are on your platform, 1? Then we don't
> >> need so specific name, just num_rx_queue.
> >
> > There are 2 RX queues, but we provide only device stats information from
> first queue.
> >
> > R-Car = 2x15 = 30 device stats
> > RZ/G2L = 1x15 = 15 device stats.
>
> That's pretty strange... how the RX queue #1 is called? How many RX
> queues are, at all?
For both R-Car and RZ/G2L,
-------------------------
#define NUM_RX_QUEUE 2
#define NUM_TX_QUEUE 2
Target device stat output for RZ/G2L:-
------------------------------------
root@smarc-rzg2l:~# ethtool -S eth0
NIC statistics:
rx_queue_0_current: 21852
tx_queue_0_current: 18854
rx_queue_0_dirty: 21852
tx_queue_0_dirty: 18854
rx_queue_0_packets: 21852
tx_queue_0_packets: 9427
rx_queue_0_bytes: 28224093
tx_queue_0_bytes: 1659438
rx_queue_0_mcast_packets: 498
rx_queue_0_errors: 0
rx_queue_0_crc_errors: 0
rx_queue_0_frame_errors: 0
rx_queue_0_length_errors: 0
rx_queue_0_csum_offload_errors: 0
rx_queue_0_over_errors: 0
root@smarc-rzg2l:~#
Target device stat output for R-Car Gen3:-
----------------------------------------
root@hihope-rzg2m:~# ethtool -S eth0
NIC statistics:
rx_queue_0_current: 34215
tx_queue_0_current: 14158
rx_queue_0_dirty: 34215
tx_queue_0_dirty: 14158
rx_queue_0_packets: 34215
tx_queue_0_packets: 14158
rx_queue_0_bytes: 38313586
tx_queue_0_bytes: 3222182
rx_queue_0_mcast_packets: 499
rx_queue_0_errors: 0
rx_queue_0_crc_errors: 0
rx_queue_0_frame_errors: 0
rx_queue_0_length_errors: 0
rx_queue_0_missed_errors: 0
rx_queue_0_over_errors: 0
rx_queue_1_current: 0
tx_queue_1_current: 0
rx_queue_1_dirty: 0
tx_queue_1_dirty: 0
rx_queue_1_packets: 0
tx_queue_1_packets: 0
rx_queue_1_bytes: 0
tx_queue_1_bytes: 0
rx_queue_1_mcast_packets: 0
rx_queue_1_errors: 0
rx_queue_1_crc_errors: 0
rx_queue_1_frame_errors: 0
rx_queue_1_length_errors: 0
rx_queue_1_missed_errors: 0
rx_queue_1_over_errors: 0
Cheers,
Biju
next prev parent reply other threads:[~2021-08-03 19:47 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 10:26 [PATCH net-next v2 0/8] Add Gigabit Ethernet driver support Biju Das
2021-08-02 10:26 ` [PATCH net-next v2 1/8] ravb: Add struct ravb_hw_info to driver data Biju Das
2021-08-02 15:02 ` Andrew Lunn
2021-08-02 20:42 ` Sergei Shtylyov
2021-08-03 5:57 ` Biju Das
2021-08-03 6:36 ` Biju Das
2021-08-04 19:27 ` Sergei Shtylyov
2021-08-04 20:27 ` Sergei Shtylyov
2021-08-09 12:06 ` Geert Uytterhoeven
2021-08-12 7:26 ` Biju Das
2021-08-12 7:58 ` Geert Uytterhoeven
2021-08-12 8:13 ` Biju Das
2021-08-17 11:24 ` Biju Das
2021-08-17 20:11 ` Sergey Shtylyov
2021-08-18 6:29 ` Biju Das
2021-08-18 10:11 ` Sergey Shtylyov
2021-08-18 10:23 ` Biju Das
2021-08-02 10:26 ` [PATCH net-next v2 2/8] ravb: Add skb_sz to struct ravb_hw_info Biju Das
2021-08-02 15:08 ` Andrew Lunn
2021-08-02 20:54 ` Sergei Shtylyov
2021-08-03 7:13 ` Biju Das
2021-08-02 10:26 ` [PATCH net-next v2 3/8] ravb: Add num_gstat_queue " Biju Das
2021-08-02 15:09 ` Andrew Lunn
2021-08-03 18:21 ` Sergei Shtylyov
2021-08-03 19:13 ` Biju Das
2021-08-03 19:22 ` Sergei Shtylyov
2021-08-03 19:47 ` Biju Das [this message]
2021-08-17 15:08 ` Biju Das
2021-08-02 10:26 ` [PATCH net-next v2 4/8] ravb: Add stats_len " Biju Das
2021-08-03 18:35 ` Sergei Shtylyov
2021-08-03 18:47 ` Biju Das
2021-08-03 19:20 ` Sergei Shtylyov
2021-08-02 10:26 ` [PATCH net-next v2 5/8] ravb: Add gstrings_stats and gstrings_size " Biju Das
2021-08-02 15:11 ` Andrew Lunn
2021-08-04 20:36 ` Sergei Shtylyov
2021-08-02 10:26 ` [PATCH net-next v2 6/8] ravb: Add net_features and net_hw_features " Biju Das
2021-08-02 15:12 ` Andrew Lunn
2021-08-05 19:07 ` Sergei Shtylyov
2021-08-05 19:18 ` Biju Das
2021-08-06 20:20 ` Sergei Shtylyov
2021-08-12 7:35 ` Biju Das
2021-08-06 20:31 ` Sergei Shtylyov
2021-08-02 10:26 ` [PATCH net-next v2 7/8] ravb: Add internal delay hw feature " Biju Das
2021-08-02 15:13 ` Andrew Lunn
2021-08-03 21:06 ` Sergei Shtylyov
2021-08-04 6:19 ` Biju Das
2021-08-03 21:12 ` Sergei Shtylyov
2021-08-04 5:13 ` Biju Das
2021-08-04 9:51 ` Sergey Shtylyov
2021-08-04 10:08 ` Biju Das
2021-08-04 10:34 ` Sergei Shtylyov
2021-08-04 10:20 ` Sergei Shtylyov
2021-08-04 10:32 ` Biju Das
2021-08-02 10:26 ` [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs " Biju Das
2021-08-02 15:14 ` Andrew Lunn
2021-08-04 20:50 ` Sergei Shtylyov
2021-08-17 15:47 ` Biju Das
2021-08-17 16:30 ` Sergey Shtylyov
2021-08-17 16:33 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59220F188237ADB3BBFDBD5186F09@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omprussia.ru \
--cc=sergei.shtylyov@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).