linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support
Date: Thu, 12 Aug 2021 07:17:31 +0000	[thread overview]
Message-ID: <OS0PR01MB592233D07AA6E4750267799786F99@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXJY62vYx-ukDtdARg5duWqyKnL1CsoXEvf7-CfRcLZ0g@mail.gmail.com>

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy
> and host support
> 
> Hi Biju,
> 
> On Tue, Jul 27, 2021 at 8:55 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Add USB2.0 phy and host support to SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -200,6 +200,100 @@
> >                               <0x0 0x11940000 0 0x60000>;
> >                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> >                 };
> > +
> > +               phyrst: usbphy-ctrl@11c40000 {
> > +                       compatible = "renesas,r9a07g044-usbphy-ctrl",
> > +                                    "renesas,rzg2l-usbphy-ctrl";
> > +                       reg = <0 0x11c40000 0 0x10000>;
> > +                       clocks = <&cpg CPG_MOD R9A07G044_USB_PCLK>;
> > +                       resets = <&cpg R9A07G044_USB_PRESETN>;
> > +                       power-domains = <&cpg>;
> > +                       #reset-cells = <1>;
> 
> Should there be a status = "disabled"?

OK, will add it in SoC dtsi, since all RZ/G2L based boards have USB support.

In future, if there is a requirement for handling of permanently unused pin
as mentioned in section "34.4.2. Handling of permanently unused pin"
then we need to enable this driver in SoC dtsi. with dt-binding and driver probe 
changes for handling the same.

Cheers,
Biju

> 
> > +               };
> 
> The rest looks good to me, so with the above clarified:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

  reply	other threads:[~2021-08-12  7:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 18:55 [PATCH v5 0/6] Add USB2.0 support Biju Das
2021-07-27 18:55 ` [PATCH v5 1/6] arm64: configs: defconfig: Enable RZ/G2L USBPHY control driver Biju Das
2021-07-27 18:55 ` [PATCH v5 2/6] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Biju Das
2021-08-02 20:55   ` Rob Herring
2021-08-04  9:38   ` Yoshihiro Shimoda
2021-08-06 12:42   ` Vinod Koul
2021-07-27 18:55 ` [PATCH v5 3/6] phy: renesas: phy-rcar-gen3-usb2: Add USB2.0 PHY support for RZ/G2L Biju Das
2021-08-04  9:38   ` Yoshihiro Shimoda
2021-08-06 12:43   ` Vinod Koul
2021-07-27 18:55 ` [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support Biju Das
2021-08-10 10:19   ` Geert Uytterhoeven
2021-08-12  7:17     ` Biju Das [this message]
2021-07-27 18:55 ` [PATCH v5 5/6] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2021-08-02 20:56   ` Rob Herring
2021-07-27 18:55 ` [PATCH v5 6/6] arm64: dts: renesas: r9a07g044: Add USB2.0 device support Biju Das
2021-08-10 10:20   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS0PR01MB592233D07AA6E4750267799786F99@OS0PR01MB5922.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --subject='RE: [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).