linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Vinod Koul <vkoul@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Biju Das <biju.das@bp.renesas.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support
Date: Sat, 31 Jul 2021 06:42:13 +0000	[thread overview]
Message-ID: <OS0PR01MB5922641004F8B0029490332F86ED9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSZPR01MB7019905B23FA514DB08987DDAAEC9@OSZPR01MB7019.jpnprd01.prod.outlook.com>

Hi Mark and Prabhakar,

+ Vinod.

The first binding patch is for SSI support in interrupt mode. so it is ok.

The second binding patch is for adding DMA support in ssi.
The example value in #dma-cells need to be updated. Earlier it was just MID/RID value.

Based on recent discussion with Vinod and Geert, It needs to updated with encoded values of 
MID/RID value and legacy channel configuration parameters, as passing the later to driver
using slave_config is not recommended.

So either drop the second patch or Will send a follow up patch fixing the example

+            dmas = <&dmac 0x2655>,
+                   <&dmac 0x2656>;

Please let me know.

Regards,
Biju

> -----Original Message-----
> From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Sent: 30 July 2021 20:13
> To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>; Liam
> Girdwood <lgirdwood@gmail.com>; Rob Herring <robh+dt@kernel.org>; Jaroslav
> Kysela <perex@perex.cz>; Philipp Zabel <p.zabel@pengutronix.de>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>; Chris Brandt
> <Chris.Brandt@renesas.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> Geert Uytterhoeven <geert+renesas@glider.be>; alsa-devel@alsa-project.org;
> linux-renesas-soc@vger.kernel.org; Biju Das <biju.das@bp.renesas.com>;
> devicetree@vger.kernel.org
> Subject: RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support
> 
> Hi Mark,
> 
> > -----Original Message-----
> > From: Mark Brown <broonie@kernel.org>
> > Sent: 30 July 2021 20:04
> > To: Takashi Iwai <tiwai@suse.com>; Liam Girdwood
> > <lgirdwood@gmail.com>; Rob Herring <robh+dt@kernel.org>; Jaroslav
> > Kysela <perex@perex.cz>; Philipp Zabel <p.zabel@pengutronix.de>; Biju
> > Das <biju.das.jz@bp.renesas.com>
> > Cc: Mark Brown <broonie@kernel.org>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>; Chris Brandt
> > <Chris.Brandt@renesas.com>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; Geert Uytterhoeven
> > <geert+renesas@glider.be>; alsa-devel@alsa- project.org;
> > linux-renesas-soc@vger.kernel.org; Biju Das <biju.das@bp.renesas.com>;
> > devicetree@vger.kernel.org
> > Subject: Re: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support
> >
> > On Mon, 19 Jul 2021 14:40:32 +0100, Biju Das wrote:
> > > This patch series aims to add ASoC support on RZ/G2L SoC's.
> > >
> > > It is based on the work done by Chris Brandt for RZ/A ASoC driver.
> > >
> > > Biju Das (8):
> > >   ASoC: dt-bindings: Document RZ/G2L bindings
> > >   sound: soc: sh: Add RZ/G2L SSIF-2 driver
> > >   arm64: dts: renesas: r9a07g044: Add external audio clock nodes
> > >   arm64: dts: renesas: r9a07g044: Add SSI support
> > >   arm64: defconfig: Enable ASoC sound support for RZ/G2L SoC
> > >   ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
> > >   sound: sh: rz-ssi: Add SSI DMAC support
> > >   arm64: dts: renesas: r9a07g044: Add SSI DMA support
> > >
> > > [...]
> >
> > Applied to
> >
> >
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2
> > Fkernel%2Fgit%2Fbroonie%2Fsound.git&amp;data=04%7C01%7Cprabhakar.mahad
> > ev-
> > lad.rj%40bp.renesas.com%7C60c047db42e149eacdb808d9538ccc7e%7C53d82571d
> > a1947e49cb4625a166a4a2a%7C0%7C0%
> > 7C637632686468564246%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
> > joiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> > CI6Mn0%3D%7C1000&amp;sdata=Rdyi2vXY9i%2Fly%2FOTWVFmc8k0rVbpM75FthJn7ri
> > jxwU%3D&amp;reserved=0 for-next
> >
> > Thanks!
> >
> > [1/8] ASoC: dt-bindings: Document RZ/G2L bindings
> >       commit: 2b761f476f3a6e0a212c8c88e7855f66edb177e0
> > [6/8] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
> >       commit: 5df6dfbb6de815ba3a75c788a916865212fd5221
> >
> There is a updated version of the patch [1] which was posted yesterday due
> to change in handling DMA slave channel configuration [2]. Both the queued
> patches need to dropped.
> 
> [1] https://patchwork.kernel.org/project/linux-renesas-
> soc/patch/20210729172311.31111-2-biju.das.jz@bp.renesas.com/
> [2] https://patchwork.kernel.org/project/linux-renesas-
> soc/patch/20210729082520.26186-2-biju.das.jz@bp.renesas.com/
> 
> Cheers,
> Prabhakar
> 
> > All being well this means that it will be integrated into the
> > linux-next tree (usually sometime in the next 24 hours) and sent to
> > Linus during the next merge window (or sooner if it is a bug fix),
> however if problems are discovered then the patch may be dropped or
> reverted.
> >
> > You may get further e-mails resulting from automated or manual testing
> > and review of the tree, please engage with people reporting problems
> > and send followup patches addressing any issues that are reported if
> needed.
> >
> > If any updates are required or you are submitting further changes they
> > should be sent as incremental updates against current git, existing
> patches will not be replaced.
> >
> > Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> >
> > Thanks,
> > Mark

  reply	other threads:[~2021-07-31  6:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 13:40 Biju Das
2021-07-19 13:40 ` [PATCH v2 1/8] ASoC: dt-bindings: Document RZ/G2L bindings Biju Das
2021-07-19 22:16   ` Rob Herring
2021-07-20 11:24     ` Biju Das
2021-07-29 19:11   ` Rob Herring
2021-07-19 13:40 ` [PATCH v2 2/8] sound: soc: sh: Add RZ/G2L SSIF-2 driver Biju Das
2021-07-20  9:57   ` Geert Uytterhoeven
2021-07-20 10:24     ` Biju Das
2021-07-19 13:40 ` [PATCH v2 3/8] arm64: dts: renesas: r9a07g044: Add external audio clock nodes Biju Das
2021-07-19 13:40 ` [PATCH v2 4/8] arm64: dts: renesas: r9a07g044: Add SSI support Biju Das
2021-07-19 13:40 ` [PATCH v2 5/8] arm64: defconfig: Enable ASoC sound support for RZ/G2L SoC Biju Das
2021-07-19 13:40 ` [PATCH v2 6/8] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support Biju Das
2021-07-29 19:13   ` Rob Herring
2021-07-19 13:40 ` [PATCH v2 7/8] sound: sh: rz-ssi: Add SSI DMAC support Biju Das
2021-07-19 13:40 ` [PATCH v2 8/8] arm64: dts: renesas: r9a07g044: Add SSI DMA support Biju Das
2021-07-30 19:03 ` (subset) [PATCH v2 0/8] Add RZ/G2L Sound support Mark Brown
2021-07-30 19:13   ` Prabhakar Mahadev Lad
2021-07-31  6:42     ` Biju Das [this message]
2021-08-02 12:16     ` Mark Brown
2021-08-02 12:32       ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS0PR01MB5922641004F8B0029490332F86ED9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Brandt@renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=biju.das@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=perex@perex.cz \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    --subject='RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).