From: Biju Das <biju.das.jz@bp.renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings
Date: Fri, 13 Aug 2021 18:10:42 +0000 [thread overview]
Message-ID: <OS0PR01MB59228CA22DBE9A33DF0ADD1E86FA9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YRauzGwUUceTmlyG@robh.at.kernel.org>
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document
> RZ/G2L bindings
>
> On Wed, Aug 04, 2021 at 05:13:25PM +0100, Biju Das wrote:
> > Document RZ/G2L SDHI controller bindings.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v2->v3:
> > * This patch depends up on the previous patch in this series.
> > v1->v2:
> > * Fixed dtbs-check issue for RZ/A{1,2} platforms.
> > ---
> > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 54 +++++++++++++------
> > 1 file changed, 37 insertions(+), 17 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 543eeb825dc3..e195ee5c0900 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -44,19 +44,20 @@ properties:
> > - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
> > - items:
> > - enum:
> > - - renesas,sdhi-r8a774a1 # RZ/G2M
> > - - renesas,sdhi-r8a774b1 # RZ/G2N
> > - - renesas,sdhi-r8a774c0 # RZ/G2E
> > - - renesas,sdhi-r8a774e1 # RZ/G2H
> > - - renesas,sdhi-r8a7795 # R-Car H3
> > - - renesas,sdhi-r8a7796 # R-Car M3-W
> > - - renesas,sdhi-r8a77961 # R-Car M3-W+
> > - - renesas,sdhi-r8a77965 # R-Car M3-N
> > - - renesas,sdhi-r8a77970 # R-Car V3M
> > - - renesas,sdhi-r8a77980 # R-Car V3H
> > - - renesas,sdhi-r8a77990 # R-Car E3
> > - - renesas,sdhi-r8a77995 # R-Car D3
> > - - renesas,sdhi-r8a779a0 # R-Car V3U
> > + - renesas,sdhi-r8a774a1 # RZ/G2M
> > + - renesas,sdhi-r8a774b1 # RZ/G2N
> > + - renesas,sdhi-r8a774c0 # RZ/G2E
> > + - renesas,sdhi-r8a774e1 # RZ/G2H
> > + - renesas,sdhi-r8a7795 # R-Car H3
> > + - renesas,sdhi-r8a7796 # R-Car M3-W
> > + - renesas,sdhi-r8a77961 # R-Car M3-W+
> > + - renesas,sdhi-r8a77965 # R-Car M3-N
> > + - renesas,sdhi-r8a77970 # R-Car V3M
> > + - renesas,sdhi-r8a77980 # R-Car V3H
> > + - renesas,sdhi-r8a77990 # R-Car E3
> > + - renesas,sdhi-r8a77995 # R-Car D3
> > + - renesas,sdhi-r8a779a0 # R-Car V3U
> > + - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
> > - const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
> >
> > reg:
> > @@ -68,13 +69,11 @@ properties:
> >
> > clocks:
> > minItems: 1
> > - maxItems: 2
> > + maxItems: 4
> >
> > clock-names:
> > minItems: 1
> > - items:
> > - - const: core
> > - - const: cd
> > + maxItems: 4
>
> The names need to be defined.
Will do. Here we have 3 cases, single clock-name for majority of SoC's, Two clock-names for sdhi-r7s9210 ("core" and "cd")
and 4 clock names for sdhi-r9a07g044 ("mainclk1", "mainclk2", "hsclk" and "busclk")
Cheers,
Biju
>
> >
> > dmas:
> > minItems: 4
> > @@ -135,6 +134,8 @@ allOf:
> > - renesas,sdhi-r7s9210
> > then:
> > properties:
> > + clocks:
> > + maxItems: 2
> > clock-names:
> > items:
> > - const: core
> > @@ -146,6 +147,25 @@ allOf:
> > sectioned off to be run by a separate second clock source to
> allow
> > the main core clock to be turned off to save power.
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,sdhi-r9a07g044
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: IMCLK, SDHI channel main clock1.
> > + - description: IMCLK2, SDHI channel main clock2. When this
> clock is
> > + turned off, external SD card detection
> cannot be
> > + detected.
> > + - description: CLK_HS, SDHI channel High speed clock which
> operates
> > + 4 times that of SDHI channel main clock1.
> > + - description: ACLK, SDHI channel bus clock.
> > + required:
> > + - resets
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.17.1
> >
> >
prev parent reply other threads:[~2021-08-13 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 16:13 [PATCH v3 0/2] Document RZ/G2L SDHI controller bindings Biju Das
2021-08-04 16:13 ` [PATCH v3 1/2] dt-bindings: mmc: renesas,sdhi: Fix dtbs-check warning Biju Das
2021-08-13 17:39 ` Rob Herring
2021-08-13 18:03 ` Biju Das
2021-08-04 16:13 ` [PATCH v3 2/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L bindings Biju Das
2021-08-13 17:41 ` Rob Herring
2021-08-13 18:10 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59228CA22DBE9A33DF0ADD1E86FA9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).