linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v2] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP
Date: Thu, 12 Aug 2021 08:59:58 +0000	[thread overview]
Message-ID: <OS0PR01MB5922DDDBA73FB25B700B1E2A86F99@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVSWks7f31O3y4QuZLnztoQgG04CuCiZ9Beo-qKezNmbw@mail.gmail.com>

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v2] dt-bindings: net: renesas,etheravb: Document
> Gigabit Ethernet IP
> 
> Hi Biju,
> 
> On Tue, Jul 27, 2021 at 2:35 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Document Gigabit Ethernet IP found on RZ/G2L SoC.
> >
> > Gigabit Ethernet Interface includes Ethernet controller (E-MAC),
> > Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory
> > access controller (DMAC) for transferring transmitted Ethernet frames
> > to and received Ethernet frames from respective storage areas in the
> > URAM at high speed.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> 
> > @@ -145,14 +142,20 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: renesas,etheravb-rcar-gen2
> > +            enum:
> > +              - renesas,etheravb-rcar-gen2
> > +              - renesas,rzg2l-gbeth
> >      then:
> >        properties:
> >          interrupts:
> > -          maxItems: 1
> > +          minItems: 1
> > +          maxItems: 3
> >          interrupt-names:
> > +          minItems: 1
> >            items:
> >              - const: mux
> > +            - const: int_fil_n
> > +            - const: int_arp_ns_n
> 
> I'm aware Rob has already applied this, but should the "int_" prefix be
> dropped?

OK. I will use "fil" and "arp" instead.

> The "_n" suffix is also a bit weird (albeit it matches the documentation).
> Usually it is used to indicate an active-low signal, but the interrupt is
> declared in the .dtsi with IRQ_TYPE_LEVEL_HIGH.
> 

But here on the interrupt mapping table(RZG2L_InterruptMapping_rev01.xlsx). It is mentioned as high. So I guess, it is correct.

> And the first interrupt is not a mux on RZ/G2L, but called "pif_int_n"
> (whatever "pif" might mean).

As per section 32.5.12 Interrupts, this interrupt include, Descriptor interrupts,
Error interrupts, reception interrupts and transmission interrupts.

The source status can be checked from individual status register. 

For me. This description looks like a mux interrupt.
Multiple interrupt sources ored together to generate an interrupt and status can be 
Checked from each individual register. 
Please let me know if my understanding is wrong.

I agree, on HW manual it is mentioned as pif_int_n. I can replace mux with pif instead. Please let me know.

Regards,
Biju




> 
> >          rx-internal-delay-ps: false
> >      else:
> >        properties:
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

  reply	other threads:[~2021-08-12  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 12:34 Biju Das
2021-08-02 20:15 ` Rob Herring
2021-08-12  8:27 ` Geert Uytterhoeven
2021-08-12  8:59   ` Biju Das [this message]
2021-08-12  9:07     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS0PR01MB5922DDDBA73FB25B700B1E2A86F99@OS0PR01MB5922.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@gmail.com \
    --subject='RE: [PATCH v2] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).