From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Ramesh Shanmugasundaram <rashanmu@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: RE: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema
Date: Wed, 23 Sep 2020 14:08:41 +0000 [thread overview]
Message-ID: <OSAPR01MB27407BFEBF870A5F3DB40D15C2380@OSAPR01MB2740.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXbhqYPrFDa4rY4xM_wQcVRCr3Lh=EQHbS+jAQvLADvhg@mail.gmail.com>
Hi Geert,
Thank you for getting back to me.
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 September 2020 14:33
>
> Hi Fabrizio,
>
> On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> > > <fabrizio.castro.jz@renesas.com> wrote:
> > > > Convert the Renesas DRIF bindings to DT schema and update
> > > > MAINTAINERS accordingly.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> > > > +if:
> > > > + required:
> > > > + - renesas,primary-bond
> > > > +then:
> > > > + required:
> > > > + - pinctrl-0
> > > > + - pinctrl-names
> > > > + - port
> > >
> > > The last 3 properties must not be present for a secondary interface,
> > > right?
> >
> > If you have both channels enabled, then one of the two has to define
> properties:
> > * renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
> >
> > If only one channel is enabled, then the primary bond concept loses its
> value,
> > whether renesas,primary-bond is specified or not doesn’t matter anymore,
> but the
> > enabled node has to specify the pinctrl related properties and the port.
> >
> > > To express that, I think you need to add:
> > >
> > > else:
> > > properties:
> > > - pinctrl-0: false
> > > - pinctrl-names: false
> > > - port: false
> >
> > If I went with this, we would not be able to allow those properties to be
> specified in the
> > only enabled node for single channels configurations.
> >
> > Is there a better way to approach this?
> >
> > I'll wait for this point to get sorted before sending v3 out.
>
> The old binding said:
>
> -Required properties of an internal channel when:
> - - It is the only enabled channel of the bond (or)
> - - If it acts as primary among enabled bonds
>
> -- renesas,primary-bond: empty property indicating the channel
> acts as primary
> - among the bonded channels.
>
> so renesas,primary-bond is required for the only enabled node for
> single channels configurations anyway?
The old binding also said:
"
When only one of the bonded channels need to be enabled, the property
"renesas,bonding" or "renesas,primary-bond" will have no effect. That
enabled channel can act alone as any other independent device.
"
If you then look at the driver implementation, the renesas,primary-bond
property doesn’t get evaluated if you have only one channel enabled.
Thanks,
Fab
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
next prev parent reply other threads:[~2020-09-23 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 10:59 [PATCH v2 0/3] Document r8a77990 DRIF support Fabrizio Castro
2020-09-16 10:59 ` [PATCH v2 1/3] MAINTAINERS: Add Fabrizio Castro to Renesas DRIF Fabrizio Castro
2020-09-20 11:22 ` Ramesh Shanmugasundaram
2020-09-23 16:02 ` Laurent Pinchart
2020-09-24 8:53 ` Fabrizio Castro
2020-09-16 10:59 ` [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema Fabrizio Castro
2020-09-23 10:07 ` Geert Uytterhoeven
2020-09-23 11:55 ` Fabrizio Castro
2020-09-23 13:33 ` Geert Uytterhoeven
2020-09-23 14:08 ` Fabrizio Castro [this message]
2020-09-16 10:59 ` [PATCH v2 3/3] media: dt-bindings: media: renesas,drif: Add r8a77990 support Fabrizio Castro
2020-09-23 15:38 ` Rob Herring
2020-09-17 0:55 ` [PATCH v2 0/3] Document r8a77990 DRIF support Laurent Pinchart
2020-09-17 9:34 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB27407BFEBF870A5F3DB40D15C2380@OSAPR01MB2740.jpnprd01.prod.outlook.com \
--to=fabrizio.castro.jz@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rashanmu@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).