From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Biju Das <biju.das@bp.renesas.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Simon Horman <horms+renesas@verge.net.au>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Kees Cook <keescook@chromium.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: RE: [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role switch support
Date: Tue, 21 May 2019 07:34:41 +0000 [thread overview]
Message-ID: <OSAPR01MB30893CC5002CCE99A2135683D8070@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSBPR01MB21032BF17963E11F3D2F7B39B8070@OSBPR01MB2103.jpnprd01.prod.outlook.com>
Hi Biju-san,
> From: Biju Das, Sent: Tuesday, May 21, 2019 4:10 PM
>
> Hi Shimoda-San,
>
> Thanks for the feedback.
>
> > > From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM
> > > Subject: [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role
> > > switch support
> >
> > Now I'm confusing about the "Add dual role switch support" mean...
> > Especially, this driver has already supports dual role switch support by own
> > sysfs or debugfs.
>
> Sorry for the confusion.
> What about "Enhance role switch support" ?
Thank you for the suggestion. It's good to me.
> > > The RZ/G2E cat874 board has a type-c connector connected to hd3ss3220
> > > usb type-c drp port controller. This patch adds dual role switch
> > > support for the type-c connector using the usb role switch class framework.
> >
> > IIUC, after this patch is applied, the hs3ss3220 type-c driver can switch the
> > role by using the usb role switch class framework.
>
> Yes, That is correct. HD3SS3220 driver detects host/device connection events (attach/detach) and
> It calls "usb_role_switch_set_role" to assign/switch the role.
I got it.
<snip>
> > JFYI, according to the binding document [1], this "usb-role-switch" means:
> > ---
> > + - usb-role-switch: boolean, indicates that the device is capable of assigning
> > + the USB data role (USB host or USB device) for a
> > given
> > + USB connector, such as Type-C, Type-B(micro).
> > + see connector/usb-connector.txt.
> > ---
> >
> > So, R-Car Gen3 / Salvator-XS cannot have this property because the board
> > has Type-A connector.
> >
> > [1] https://patchwork.kernel.org/patch/10934835/
>
> I have updated the binding patch to cover this[1]
> [1]. https://patchwork.kernel.org/patch/10944631/
> Are you ok with this binding patch?
I'm sorry, I overlooked the patch. I'll check it later.
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-05-21 7:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 12:09 [PATCH v6 0/7] Add USB3.0 and TI HD3SS3220 driver support Biju Das
2019-05-15 12:09 ` [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das
2019-05-15 16:09 ` Sergei Shtylyov
2019-05-21 9:42 ` Biju Das
2019-05-21 8:03 ` Yoshihiro Shimoda
2019-05-21 8:08 ` Kuninori Morimoto
2019-05-22 10:59 ` Biju Das
2019-05-23 5:18 ` Yoshihiro Shimoda
2019-05-23 8:56 ` Biju Das
2019-05-15 12:09 ` [PATCH v6 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Biju Das
2019-05-21 8:27 ` Yoshihiro Shimoda
2019-05-28 7:25 ` Biju Das
2019-05-15 12:09 ` [PATCH v6 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das
2019-05-15 12:09 ` [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role switch support Biju Das
2019-05-16 3:16 ` Chunfeng Yun
2019-05-16 8:00 ` Biju Das
2019-05-21 5:49 ` Yoshihiro Shimoda
2019-05-21 7:10 ` Biju Das
2019-05-21 7:34 ` Yoshihiro Shimoda [this message]
2019-05-15 12:09 ` [PATCH v6 5/7] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das
2019-05-15 12:09 ` [PATCH v6 6/7] arm64: dts: renesas: r8a774c0-cat874: Enable USB3.0 host/peripheral device node Biju Das
2019-05-15 12:09 ` [PATCH v6 7/7] arm64: dts: renesas: r8a774c0-cat874: Enable usb role switch support Biju Das
2019-05-24 21:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB30893CC5002CCE99A2135683D8070@OSAPR01MB3089.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=balbi@kernel.org \
--cc=biju.das@bp.renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms+renesas@verge.net.au \
--cc=horms@verge.net.au \
--cc=keescook@chromium.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).