From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2] watchdog: renesas_wdt: Add a few cycles delay
Date: Wed, 5 Jun 2019 04:58:41 +0000 [thread overview]
Message-ID: <OSAPR01MB3089F2A14EBFB985F3E37609D8160@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190603130415.wfqwyya4etbmmser@ninjato>
Hi Wolfram-san,
> From: Wolfram Sang, Sent: Monday, June 3, 2019 10:04 PM
> On Mon, Jun 03, 2019 at 07:36:01PM +0900, Yoshihiro Shimoda wrote:
> > According to the hardware manual of R-Car Gen2 and Gen3,
> > software should wait a few RLCK cycles as following:
> > - Delay 2 cycles before setting watchdog counter.
> > - Delay 3 cycles before disabling module clock.
> >
> > So, this patch adds such delays.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Despite minor nits:
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thank you for your review!
> > +static void rwdt_wait(struct rwdt_priv *priv, unsigned int cycles)
>
> I'd think 'rwdt_wait_cycles' would be a more precise name for this
> function.
>
> > + unsigned long delays;
>
> Why not just 'delay'?
Ah, in v1, periods value existed. So, for consistence, I named "delay".
But, I think we should just "delay" in this case. I'll fix it.
> > + /* Delay 3 cycles before disabling module clock */
>
> I like the comments explaining why it is needed.
I think so!
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-06-05 4:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 10:36 [PATCH v2] watchdog: renesas_wdt: Add a few cycles delay Yoshihiro Shimoda
2019-06-03 13:04 ` Wolfram Sang
2019-06-05 4:58 ` Yoshihiro Shimoda [this message]
2019-06-03 16:23 ` Niklas Söderlund
2019-06-05 5:01 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB3089F2A14EBFB985F3E37609D8160@OSAPR01MB3089.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).