From: Biju Das <biju.das@bp.renesas.com>
To: Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: RE: [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig
Date: Wed, 24 Apr 2019 09:44:11 +0000 [thread overview]
Message-ID: <OSBPR01MB210316C686F7DFABE8013357B83C0@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190424093315.6jg7muf56d2toxl5@verge.net.au>
Hi Simon,
Thanks for the feedback.
I missed to add the dependency for this patch.
This patch has dependency on
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01
regards,
Biju
> -----Original Message-----
> From: Simon Horman <horms@verge.net.au>
> Sent: 24 April 2019 10:33
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Biju Das <biju.das@bp.renesas.com>; Magnus Damm
> <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; Linux-
> Renesas <linux-renesas-soc@vger.kernel.org>; Linux ARM <linux-arm-
> kernel@lists.infradead.org>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from
> shmobile_defconfig
>
> On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote:
> > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@bp.renesas.com>
> wrote:
> > > Remove the GENERIC_PHY config option from shmobile_defconfig, as it
> > > is selected by PHY_RCAR_GEN3_USB2.
> > >
> > > PHY_RCAR_GEN3_USB2 is enabled by the commit
> > > 0cd4f4f10245d1d9616e00245
> > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in
> shmobile_defconfig").
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> This does not seem to work as expected when applied on top of renesas-
> devel-20190423-v5.1-rc5.
>
> Without this patch I see both CONFIG_GENERIC_PHY and
> CONFIG_PHY_RCAR_GEN selected. With this patch I see neither selected, I
> expected both.
>
> --- .config.old 2019-04-24 11:31:12.480520934 +0200
> +++ .config 2019-04-24 11:31:34.732852122 +0200
> @@ -4272,7 +4272,7 @@
> #
> # PHY Subsystem
> #
> -CONFIG_GENERIC_PHY=y
> +# CONFIG_GENERIC_PHY is not set
> # CONFIG_BCM_KONA_USB2_PHY is not set
> # CONFIG_PHY_CADENCE_DP is not set
> # CONFIG_PHY_CADENCE_DPHY is not set
> @@ -4282,7 +4282,6 @@
> # CONFIG_PHY_PXA_28NM_USB2 is not set
> # CONFIG_PHY_CPCAP_USB is not set
> # CONFIG_PHY_MAPPHONE_MDM6600 is not set -
> CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set #
> CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not set
next prev parent reply other threads:[~2019-04-24 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 13:13 [PATCH] ARM: shmobile: Remove GENERIC_PHY from shmobile_defconfig Biju Das
2019-04-24 7:12 ` Geert Uytterhoeven
2019-04-24 9:33 ` Simon Horman
2019-04-24 9:44 ` Biju Das [this message]
2019-04-24 11:07 ` Simon Horman
2019-04-24 11:11 ` Biju Das
2019-04-26 10:12 ` Simon Horman
2019-04-26 10:14 ` Biju Das
2019-05-20 11:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB210316C686F7DFABE8013357B83C0@OSBPR01MB2103.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).