From: Biju Das <biju.das@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: RE: [PATCH v2 2/8] soc: renesas: rcar-sysc: Add r8a774b1 support
Date: Mon, 23 Sep 2019 06:42:13 +0000 [thread overview]
Message-ID: <OSBPR01MB2103BCC545F3F4C4AFB3A61CB8850@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUvVKYZuzS7Z9uiN=KmdKm6GPnGS0oZbGZKfkbaUOB+Ng@mail.gmail.com>
HI Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v2 2/8] soc: renesas: rcar-sysc: Add r8a774b1 support
>
> Hi Biju,
>
> On Thu, Sep 19, 2019 at 10:17 AM Biju Das <biju.das@bp.renesas.com>
> wrote:
> > Add support for RZ/G2N (R8A774B1) SoC power areas to the R-Car SYSC
> > driver.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/drivers/soc/renesas/r8a774b1-sysc.c
> > @@ -0,0 +1,35 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Renesas RZ/G2N System Controller
> > + * Copyright (C) 2019 Renesas Electronics Corp.
> > + *
> > + * Based on Renesas R-Car M3-W System Controller
> > + * Copyright (C) 2016 Glider bvba
> > + */
> > +
> > +#include <linux/bug.h>
>
> This include doesn't seem to be used?
OK, Will remove .
> > +#include <linux/kernel.h>
> > +
> > +#include <dt-bindings/power/r8a774b1-sysc.h>
> > +
> > +#include "rcar-sysc.h"
> > +
> > +static const struct rcar_sysc_area r8a774b1_areas[] __initconst = {
> > + { "always-on", 0, 0, R8A774B1_PD_ALWAYS_ON, -1,
> PD_ALWAYS_ON },
> > + { "ca57-scu", 0x1c0, 0, R8A774B1_PD_CA57_SCU,
> R8A774B1_PD_ALWAYS_ON,
> > + PD_SCU },
> > + { "ca57-cpu0", 0x80, 0, R8A774B1_PD_CA57_CPU0,
> R8A774B1_PD_CA57_SCU,
> > + PD_CPU_NOCR },
> > + { "ca57-cpu1", 0x80, 1, R8A774B1_PD_CA57_CPU1,
> R8A774B1_PD_CA57_SCU,
> > + PD_CPU_NOCR },
> > + { "a3vc", 0x380, 0, R8A774B1_PD_A3VC,
> R8A774B1_PD_ALWAYS_ON },
> > + { "a3vp", 0x340, 0, R8A774B1_PD_A3VP,
> R8A774B1_PD_ALWAYS_ON },
> > + { "a2vc1", 0x3c0, 1, R8A774B1_PD_A2VC1, R8A774B1_PD_A3VC },
> > + { "3dg-a", 0x100, 0, R8A774B1_PD_3DG_A,
> R8A774B1_PD_ALWAYS_ON },
> > + { "3dg-b", 0x100, 1, R8A774B1_PD_3DG_B, R8A774B1_PD_3DG_A
> },
> > +};
> > +
> > +const struct rcar_sysc_info r8a774b1_sysc_info __initconst = {
> > + .areas = r8a774b1_areas,
> > + .num_areas = ARRAY_SIZE(r8a774b1_areas),
>
> Given the Hardware User's Manual documents the presence of the
> SYSCEXTMASK register on RZ/G2N, you want to fill in the .extmask_{offs,val}
> fields, too.
Will Send V3, with the above changes.
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2019-09-23 6:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 8:17 [PATCH v2 0/8] Add RZ/G2N SYSC/RST/Clock/PFC support Biju Das
2019-09-19 8:17 ` [PATCH v2 1/8] dt-bindings: power: rcar-sysc: Document r8a774b1 sysc Biju Das
2019-09-20 14:19 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 2/8] soc: renesas: rcar-sysc: Add r8a774b1 support Biju Das
2019-09-20 14:54 ` Geert Uytterhoeven
2019-09-20 15:29 ` Geert Uytterhoeven
2019-09-23 6:42 ` Biju Das [this message]
2019-09-19 8:17 ` [PATCH v2 3/8] dt-bindings: reset: rcar-rst: Document r8a774b1 reset module Biju Das
2019-09-20 15:29 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 4/8] soc: renesas: rcar-rst: Add support for RZ/G2N Biju Das
2019-09-20 15:39 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 5/8] dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding Biju Das
2019-09-20 15:40 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 6/8] clk: renesas: cpg-mssr: Add r8a774b1 support Biju Das
2019-09-27 11:28 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 7/8] dt-bindings: pinctrl: sh-pfc: Document r8a774b1 PFC support Biju Das
2019-09-20 15:41 ` Geert Uytterhoeven
2019-09-19 8:17 ` [PATCH v2 8/8] pinctrl: sh-pfc: r8a77965: Add R8A774B1 " Biju Das
2019-09-20 15:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB2103BCC545F3F4C4AFB3A61CB8850@OSBPR01MB2103.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).