From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Chris Brandt <Chris.Brandt@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
USB list <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 11/15] usb: renesas_usbhs: Add support for RZ/A2
Date: Fri, 10 May 2019 11:00:20 +0000 [thread overview]
Message-ID: <OSBPR01MB317441157A3BFA9148FFF558D80C0@OSBPR01MB3174.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSBPR01MB3174FA32BADD2B97A6003ADCD80C0@OSBPR01MB3174.jpnprd01.prod.outlook.com>
Hi Geert-san, Chris-san,
> From: Yoshihiro Shimoda, Sent: Friday, May 10, 2019 5:16 PM
>
> Hi Geert-san,
>
> > From: Geert Uytterhoeven, Sent: Friday, May 10, 2019 4:07 PM
> >
> > Hi Chris,
> >
> > On Thu, May 9, 2019 at 10:14 PM Chris Brandt <chris.brandt@renesas.com> wrote:
> <snip>
> > BTW, this driver uses a mix of feature checking using USBHS_TYPE_*
> > enums, and a parameter block/callback struct
> > (renesas_usbhs_platform_callback). Perhaps the feature flags can just
> > be moved to the struct, and the various structs referenced from
> > of_device_id.data?
>
> Thank you for your comment! I think so. So, I'll make such a patch later.
I have submitted such a patch as following:
https://patchwork.kernel.org/patch/10938575/
Since usbhsc_is_multi_clks() uses the type member, each struct also has the type like previous code.
About SoC parameters, I think it is better to add members into struct renesas_usbhs_driver_param like
has_usb_dmac instead of USBHSF_* definitions. In other words, we don't need the patch 08/15 and
patch 09/15 and 10/15 should add each member for it. Chris-san, what do you think?
Best regards,
Yoshihiro Shimoda
> Best regards,
> Yoshihiro Shimoda
>
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
next prev parent reply other threads:[~2019-05-10 11:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 20:11 [PATCH v2 00/15] usb: Add host and device support for RZ/A2 Chris Brandt
2019-05-09 20:11 ` [PATCH v2 01/15] ARM: dts: r7s9210: Add USB clock Chris Brandt
2019-05-13 12:25 ` Simon Horman
2019-05-09 20:11 ` [PATCH v2 02/15] ARM: dts: rza2mevb: Add 48MHz " Chris Brandt
2019-05-13 12:26 ` Simon Horman
2019-05-09 20:11 ` [PATCH v2 03/15] phy: renesas: rcar-gen3-usb2: detect usb_x1 clock Chris Brandt
2019-05-10 1:57 ` Chunfeng Yun
2019-05-10 13:17 ` Chris Brandt
2019-05-10 4:17 ` Yoshihiro Shimoda
2019-05-10 6:56 ` Geert Uytterhoeven
2019-05-09 20:11 ` [PATCH v2 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 Chris Brandt
2019-05-10 4:38 ` Yoshihiro Shimoda
2019-05-10 6:55 ` Geert Uytterhoeven
2019-05-13 21:07 ` Chris Brandt
2019-05-13 21:12 ` Geert Uytterhoeven
2019-05-13 21:24 ` Chris Brandt
2019-05-09 20:11 ` [PATCH v2 05/15] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG Chris Brandt
2019-05-10 8:36 ` Sergei Shtylyov
2019-05-10 13:55 ` Chris Brandt
2019-05-11 7:39 ` Sergei Shtylyov
2019-05-11 12:05 ` Chris Brandt
2019-05-09 20:11 ` [PATCH v2 06/15] dt-bindings: rcar-gen3-phy-usb2: Document dr_mode Chris Brandt
2019-05-09 20:11 ` [PATCH v2 07/15] dt-bindings: rcar-gen3-phy-usb2: Add r7s9210 support Chris Brandt
2019-05-09 20:11 ` [PATCH v2 08/15] usb: renesas_usbhs: move flags macros Chris Brandt
2019-05-10 1:59 ` Chunfeng Yun
2019-05-10 8:41 ` Sergei Shtylyov
2019-05-10 14:00 ` Chris Brandt
2019-05-09 20:11 ` [PATCH v2 09/15] usb: renesas_usbhs: add support for CNEN bit Chris Brandt
2019-05-09 20:11 ` [PATCH v2 10/15] usb: renesas_usbhs: support byte addressable CFIFO Chris Brandt
2019-05-09 20:11 ` [PATCH v2 11/15] usb: renesas_usbhs: Add support for RZ/A2 Chris Brandt
2019-05-10 1:53 ` Chunfeng Yun
2019-05-10 13:10 ` Chris Brandt
2019-05-10 7:07 ` Geert Uytterhoeven
2019-05-10 8:16 ` Yoshihiro Shimoda
2019-05-10 11:00 ` Yoshihiro Shimoda [this message]
2019-05-10 14:20 ` Chris Brandt
2019-05-09 20:11 ` [PATCH v2 12/15] dt-bindings: usb: renesas_usbhs: Add support for r7s9210 Chris Brandt
2019-05-09 20:11 ` [PATCH v2 13/15] ARM: dts: r7s9210: Add USB Host support Chris Brandt
2019-05-09 20:11 ` [PATCH v2 14/15] ARM: dts: r7s9210: Add USB Device support Chris Brandt
2019-05-09 20:11 ` [PATCH v2 15/15] ARM: dts: rza2mevb: Add USB host support Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB317441157A3BFA9148FFF558D80C0@OSBPR01MB3174.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=Chris.Brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).