From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 2/3] mmc: tmio: No memory size limitation if runs on IOMMU
Date: Tue, 7 May 2019 07:13:59 +0000 [thread overview]
Message-ID: <OSBPR01MB3174418E8016F4DC6BDB9C1FD8310@OSBPR01MB3174.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190426091731.GB1031@kunai>
Hi Sergei-san, Wolfram-san,
Thank you for your review and sorry for the delayed response...
> From: Wolfram Sang, Sent: Friday, April 26, 2019 6:18 PM
>
> > > This patch adds a condition to avoid memory size limitaion of
> >
> > Limitation.
>
> "limitation" :) And maybe "a memory size limitation"?
I think so. I'll fix it on v2 patch.
> > > + * the max_req_size if needed as a workaround. However, if the driver
> > > + * runs on IOMMU, this workaround doesn't need.
> >
> > Isn't needed, maybe?
>
> Ack, "isn't needed".
I'll fix it.
> Patch itself looks good to me.
Thank you for your comment!
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-05-07 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 5:18 [PATCH 0/3] mmc: renesas_sdhi_internal_dmac: improve performance by using IOMMU Yoshihiro Shimoda
2019-04-26 5:18 ` [PATCH 1/3] mmc: tmio: add init_card ops Yoshihiro Shimoda
2019-04-26 9:15 ` Wolfram Sang
2019-04-26 9:45 ` Simon Horman
2019-04-26 9:56 ` Wolfram Sang
2019-04-26 10:17 ` Simon Horman
2019-04-26 5:18 ` [PATCH 2/3] mmc: tmio: No memory size limitation if runs on IOMMU Yoshihiro Shimoda
2019-04-26 8:09 ` Sergei Shtylyov
2019-04-26 9:17 ` Wolfram Sang
2019-05-07 7:13 ` Yoshihiro Shimoda [this message]
2019-04-26 9:45 ` Simon Horman
2019-04-26 5:18 ` [PATCH 3/3] mmc: renesas_sdhi_internal_dmac: use multiple segments if possible Yoshihiro Shimoda
2019-04-26 9:37 ` Wolfram Sang
2019-05-07 7:27 ` Yoshihiro Shimoda
2019-04-26 9:45 ` Simon Horman
2019-04-26 9:46 ` [PATCH 0/3] mmc: renesas_sdhi_internal_dmac: improve performance by using IOMMU Wolfram Sang
2019-05-07 8:58 ` Yoshihiro Shimoda
2019-05-08 4:28 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB3174418E8016F4DC6BDB9C1FD8310@OSBPR01MB3174.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).