linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Brandt <Chris.Brandt@renesas.com>
To: "linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [RFC] Is runtime_pm in the RSPI driver broken?
Date: Thu, 5 Sep 2019 17:06:29 +0000	[thread overview]
Message-ID: <TY1PR01MB1562DB9AB5D516662204C1CF8ABB0@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)

Hello SPI and Renesas people (and Geert),

Before I submit a patch, is the rspi.c driver really broken or not?

I'm working with the RZ/A2M at the moment.

Runtime pm was added by Geert back in 2014. (commit 490c97747d5d)

But I'm noticing now that if I turn off all the clocks in u-boot before 
I boot, SPI does not work.

However, if I add a pm_runtime_get_sync() call do the driver, it works 
fine.

So, am I missing something? It seems that the driver is not going to 
work correctly unless pm_runtime_get_sync() gets called.

Thank you,
Chris


             reply	other threads:[~2019-09-05 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 17:06 Chris Brandt [this message]
2019-09-06 11:29 ` [RFC] Is runtime_pm in the RSPI driver broken? Geert Uytterhoeven
2019-09-06 11:37   ` Chris Brandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB1562DB9AB5D516662204C1CF8ABB0@TY1PR01MB1562.jpnprd01.prod.outlook.com \
    --to=chris.brandt@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).