RE: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M] boards

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Simon Horman" <horms@verge.net.au>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"open list:MEDIA DRIVERS FOR RENESAS - FCP"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Chris Paterson" <Chris.Paterson2@renesas.com>,
	"Biju Das" <biju.das@bp.renesas.com>,
	"xu_shunji@hoperun.com" <xu_shunji@hoperun.com>
Subject: RE: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M] boards
Date: Wed, 15 May 2019 16:20:51 +0000	[thread overview]
Message-ID: <TY1PR01MB17709902D813EB99E16FE6D2C0090@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAL_JsqLB+7-x8i=MDpZuW0ebg5BBLJ+Y3gruf40zFSNv8_42Xg@mail.gmail.com>

Hello Rob,

Thank you for your feedback!

> From: Rob Herring <robh+dt@kernel.org>
> Sent: 15 May 2019 14:42
> Subject: Re: [PATCH 2/2] dt-bindings: arm: renesas: Add HopeRun RZ/G2[M] boards
> 
> On Wed, May 15, 2019 at 6:45 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> >
> > This patch adds board HiHope RZ/G2M (the main board, powered by
> > the R8A774A1) and board HiHope RZ/G2 EX (the expansion board
> > that sits on top of the HiHope RZ/G2M). Both boards are made
> > by Jiangsu HopeRun Software Co., Ltd. (a.k.a. HopeRun).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> >
> > ---
> > Useful links:
> > http://hihope.org/product/detail/rzg2
> > https://item.taobao.com/item.htm?spm=a2oq0.12575281.0.0.6bcf1debQpzkRS&ft=t&id=592177498472
> > http://www.hoperun.com/Cn/news/id/379
> >
> > We already know that the HiHope RZ/G2 EX will also sit on the
> > HiHope RZ/G2N, even though the HiHope RZ/G2N doesn't exist just
> > yet.
> 
> Seems like useful into to put in the commit msg.

Ok, will move the notes to the commit msg then for v2.

> 
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index 19f3798..95302b9 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -106,6 +106,14 @@ properties:
> >
> >        - description: RZ/G2M (R8A774A1)
> >          items:
> > +          - enum:
> > +              - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
> > +          - const: renesas,r8a774a1
> > +
> > +        items:
> 
> Did you run this thru the checks because this isn't valid json-schema.
> You can't have same keyword twice. This 'items' needs to be another
> list entry (i.e. add a '-').

Oops, sorry about that. Will fix in v2.

Thanks,
Fab

> 
> > +          - enum:
> > +              - hoperun,hihope-rzg2-ex # HopeRun expansion board for HiHope RZ/G2 platforms
> > +          - const: hoperun,hihope-rzg2m
> >            - const: renesas,r8a774a1
> >
> >        - description: RZ/G2E (R8A774C0)
> > --
> > 2.7.4
> >