From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sam Ravnborg <sam@ravnborg.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: RE: [PATCH v2 5/9] drm/panel: Add timings field to drm_panel
Date: Thu, 15 Aug 2019 13:49:09 +0000 [thread overview]
Message-ID: <TY1PR01MB1770F80560B2B2DFEE2F3BB7C0AC0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190815120315.GL5011@pendragon.ideasonboard.com>
Hello Laurent,
Thank you for your feedback!
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 15 August 2019 13:03
> Subject: Re: [PATCH v2 5/9] drm/panel: Add timings field to drm_panel
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Thu, Aug 15, 2019 at 12:04:29PM +0100, Fabrizio Castro wrote:
> > We need to know if the panel supports dual-link, similarly
> > to bridges, therefore add a reference to drm_timings in
> > drm_panel.
>
> Panels may also need to report setup/hold time, so it's not about
> dual-link only. I would make this explicit in the commit message.
Ok
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > v1->v2:
> > * new patch
> >
> > include/drm/drm_panel.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> > index 8c738c0..cd6ff07 100644
> > --- a/include/drm/drm_panel.h
> > +++ b/include/drm/drm_panel.h
> > @@ -26,6 +26,7 @@
> >
> > #include <linux/errno.h>
> > #include <linux/list.h>
> > +#include <drm/drm_timings.h>
>
> You can just add a forward-declaration of struct drm_timing.
Ok
Thanks,
Fab
>
> >
> > struct device_node;
> > struct drm_connector;
> > @@ -81,6 +82,7 @@ struct drm_panel_funcs {
> > * struct drm_panel - DRM panel object
> > * @drm: DRM device owning the panel
> > * @connector: DRM connector that the panel is attached to
> > + * @timings: timing information
> > * @dev: parent device of the panel
> > * @link: link from panel device (supplier) to DRM device (consumer)
> > * @funcs: operations that can be performed on the panel
> > @@ -89,6 +91,7 @@ struct drm_panel_funcs {
> > struct drm_panel {
> > struct drm_device *drm;
> > struct drm_connector *connector;
> > + const struct drm_timings *timings;
> > struct device *dev;
> >
> > const struct drm_panel_funcs *funcs;
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2019-08-15 13:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 11:04 [PATCH v2 0/9] Add dual-LVDS panel support to EK874 Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 1/9] dt-bindings: panel: lvds: Add dual-link LVDS display support Fabrizio Castro
2019-08-15 11:45 ` Laurent Pinchart
2019-08-15 13:37 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 2/9] dt-bindings: display: Add bindings for Advantech IDK-2121WR Fabrizio Castro
2019-08-15 11:47 ` Laurent Pinchart
2019-08-15 13:38 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 3/9] drm: Rename drm_bridge_timings to drm_timings Fabrizio Castro
2019-08-15 13:18 ` Laurent Pinchart
2019-08-15 13:50 ` Fabrizio Castro
2019-08-15 14:04 ` Greg Kroah-Hartman
2019-08-15 14:14 ` Laurent Pinchart
2019-08-15 14:31 ` Fabrizio Castro
2019-08-15 14:53 ` Greg Kroah-Hartman
2019-08-15 15:01 ` Fabrizio Castro
2019-08-15 18:06 ` Laurent Pinchart
2019-08-15 19:05 ` Greg Kroah-Hartman
2019-08-16 8:11 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 4/9] drm/timings: Add link flags Fabrizio Castro
2019-08-15 12:00 ` Laurent Pinchart
2019-08-15 15:40 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 5/9] drm/panel: Add timings field to drm_panel Fabrizio Castro
2019-08-15 12:03 ` Laurent Pinchart
2019-08-15 13:49 ` Fabrizio Castro [this message]
2019-08-15 14:13 ` Sam Ravnborg
2019-08-15 14:48 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 6/9] drm: rcar-du: lvds: Fix companion's mode Fabrizio Castro
2019-08-15 11:55 ` Laurent Pinchart
2019-08-15 13:42 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 7/9] drm: rcar-du: lvds: Add dual-LVDS panels support Fabrizio Castro
2019-08-15 13:08 ` Laurent Pinchart
2019-08-15 15:36 ` Fabrizio Castro
2019-08-20 16:04 ` Laurent Pinchart
2019-08-21 17:00 ` Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 8/9] drm/panel: lvds: Add support for the IDK-2121WR Fabrizio Castro
2019-08-15 11:04 ` [PATCH v2 9/9] arm64: dts: renesas: Add EK874 board with idk-2121wr display support Fabrizio Castro
2019-08-19 12:03 ` Geert Uytterhoeven
2019-08-20 13:59 ` Fabrizio Castro
2019-08-15 14:15 ` [PATCH v2 0/9] Add dual-LVDS panel support to EK874 Sam Ravnborg
2019-08-15 14:32 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB1770F80560B2B2DFEE2F3BB7C0AC0@TY1PR01MB1770.jpnprd01.prod.outlook.com \
--to=fabrizio.castro@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=airlied@linux.ie \
--cc=biju.das@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).