Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Biju Das <biju.das@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: RE: [PATCH 1/3] arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander
Date: Fri, 12 Jul 2019 13:21:59 +0000
Message-ID: <TYAPR01MB2111E5F445AC1CEA0C720BD9B8F20@TYAPR01MB2111.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdU79JQfEH5hY=wjyknE+sLpS6i3GeXYZ5Z=uzWkWDC-DA@mail.gmail.com>


Hi Geert,

Thanks for the feedback.


> Subject: Re: [PATCH 1/3] arm64: dts: renesas: hihope-common: Add PCA9654
> I/O expander
> 
> Hi Biju,
> 
> On Fri, Jul 5, 2019 at 12:20 PM Biju Das <biju.das@bp.renesas.com> wrote:
> > Enable PCA9654 GPIO expander, so that we can configure its GPIOs later.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -162,6 +162,13 @@
> >         clock-frequency = <400000>;
> >         status = "okay";
> >
> > +       gpio_expander: gpio@20 {
> > +               compatible = "onnn,pca9654";
> > +               reg = <0x20>;
> > +               gpio-controller;
> > +               #gpio-cells = <2>;
> 
> You may want to describe that the interrupt output is tied to GP5_25?

BT_REG_ON and WLAN_REG_ON are output pins. That is the reason, I haven't described the interrupt output.
If needed, I can add this. Please let me know.

> > +       };
> > +
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 10:15 [PATCH 0/3] Add WLAN/BT support Biju Das
2019-07-05 10:15 ` [PATCH 1/3] arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander Biju Das
2019-07-12 12:29   ` Geert Uytterhoeven
2019-07-12 13:21     ` Biju Das [this message]
2019-07-12 13:43       ` Geert Uytterhoeven
2019-07-05 10:15 ` [PATCH 2/3] arm64: dts: renesas: hihope-common: Add BT support Biju Das
2019-07-12 12:46   ` Geert Uytterhoeven
2019-07-05 10:15 ` [PATCH 3/3] arm64: dts: renesas: hihope-common: Add WLAN support Biju Das
2019-07-12 12:54   ` Geert Uytterhoeven
2019-07-12 13:52 ` [PATCH 0/3] Add WLAN/BT support Geert Uytterhoeven

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB2111E5F445AC1CEA0C720BD9B8F20@TYAPR01MB2111.jpnprd01.prod.outlook.com \
    --to=biju.das@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox