Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema
Date: Fri, 27 Mar 2020 02:42:03 +0000
Message-ID: <TYAPR01MB454433CC3EEC24AF8619526FD8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVuiAqqERf_ZEAqkhuTfOrn-VUj8rpuAHMwL=QdRNi3qg@mail.gmail.com>

Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Thursday, March 26, 2020 6:00 PM
<snip>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> 
> I think Rob would prefer to see
> 
>     # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

I'll fix it.

> > +  reg:
> > +    # base address and length of the registers block for the PHY.
> 
> The comment is not needed.

OK. I'll remove it.

> > +    maxItems: 1
> > +
> > +  clocks:
> > +    # clock phandle and specifier pair(s).
> 
> Likewise.

I got it.

> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    # for RZ/A2
> 
> if:
>   properties:
>     compatible:
>       items:
>         enum:
>           - renesas,usb2-phy-r7s9210

Thank you for the proposal. I'll fix it.

> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      - const: fck
> > +      - const: usb_x1
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/power/r8a7795-sysc.h>
> > +
> > +    usb-phy@ee080200 {
> > +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> > +        reg = <0 0xee080200 0 0x700>;
> 
> Examples are built with #{address,size}-cells = <1>, so
> 
>     reg = <0xee080200 0x700>;

I got it. I'll fix it.

> > +        interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&cpg CPG_MOD 703>;
> > +        #phy-cells = <1>;
> > +    };
> > +
> > +    usb-phy@ee0a0200 {
> > +        compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> > +        reg = <0 0xee0a0200 0 0x700>;
> 
> reg = <0xee0a0200 0x700>;

Yes, I'll fix it.

Best regards,
Yoshihiro Shimoda


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  5:29 [PATCH v2 0/4] dt-bindings: phy: add r8a77961 support Yoshihiro Shimoda
2020-03-26  5:29 ` [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema Yoshihiro Shimoda
2020-03-26  8:59   ` Geert Uytterhoeven
2020-03-27  2:42     ` Yoshihiro Shimoda [this message]
2020-03-26  5:29 ` [PATCH v2 2/4] dt-bindings: phy: renesas: usb2-phy: add r8a77961 support Yoshihiro Shimoda
2020-03-26  5:29 ` [PATCH v2 3/4] dt-bindings: phy: renesas: usb3-phy: convert bindings to json-schema Yoshihiro Shimoda
2020-03-26  8:52   ` Geert Uytterhoeven
2020-03-27  2:39     ` Yoshihiro Shimoda
2020-03-26  5:29 ` [PATCH v2 4/4] dt-bindings: phy: renesas: usb3-phy: add r8a77961 support Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB454433CC3EEC24AF8619526FD8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git