From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
"REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>
Subject: RE: [PATCH/RFC 00/19] arm64: dts: renesas: Initial support for R-Car M3-W+
Date: Fri, 11 Oct 2019 08:31:31 +0000 [thread overview]
Message-ID: <TYAPR01MB45444F8B8EEB971FA61D853BD8970@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191007102332.12196-1-geert+renesas@glider.be>
Hi Geert-san,
Thank you for the patches!
> From: Geert Uytterhoeven, Sent: Monday, October 7, 2019 7:23 PM
>
> Hi all,
>
> This RFC patch series adds support for the R-Car M3-W+ (R8A77961) SoC
> and the Salvator-XS board with R-Car M3-W+. This SoC is a derivative of
> R-Car M3-W (R8A77960), and also known as R-Car M3-W ES3.0.
> As this is an RFC, I'm sending it to a limited audience.
>
> Based on experience with previous SoCs in the R-Car Gen3 family, the
> following design decisions were made:
> - Use different compatible values (r8a77961-based),
> - Use different clock and SYSC DT binding definitions
> (R8A77961-based), but the same numerical values, to allow sharing
> drivers,
> - Share the pin control driver,
> - Share the clock driver,
> - Share the system controller driver.
>
> While the DT ABI is stable (hence we cannot s/r8a7796/r8a77960/ in DTS),
> kernel source code and kernel config symbols can be changed at any
> time. As changing kernel config symbols impacts the user, they weren't
> renamed yet.
>
> Questions:
> - What's the board part number of Salvator-XS with R-Car M3-W+?
RTP0RC7796SIPB0012SA5A.
> - Should r8a77961_pinmux_info (and the rename of r8a7796_pinmux_info
> to r8a77960_pinmux_info) be dropped? I added it because
> r8a7796_pinmux_info.name contains "r8a77960_pfc".
>
> - Should the CLK_R8A77961 and PINCTRL_PFC_R8A77961 symbols be dropped?
> The clock and pin control drivers are the same or almost the same,
> so the code increase by always enabling both is minimal.
>
> - Should the R8A77961 config symbols be dropped?
> - CONFIG_ARCH_R8A77961
> - CONFIG_CLK_R8A77961
> - CONFIG_PINCTRL_PFC_R8A77961
> - CONFIG_SYSC_R8A77961
I think the current implementations are OK.
> - If not, should the R8A7796 config symbols be renamed?
> - CONFIG_ARCH_R8A7796 to CONFIG_ARCH_R8A77960?
> - CONFIG_CLK_R8A7796 to CONFIG_CLK_R8A77960?
> - CONFIG_PINCTRL_PFC_R8A7796 to CONFIG_PINCTRL_PFC_R8A77960?
> - CONFIG_SYSC_R8A7796 to CONFIG_SYSC_R8A77960?
> Due to dependencies on CONFIG_ARCH_R8A7796, this should be a single
> commit.
I think so.
> Related questions for old R-Car H3 ES1.x support:
> - Should CONFIG_PINCTRL_PFC_R8A77950 be added, to allow compiling out
> R-Car H3 ES1.x pin control support?
> If yes, should CONFIG_PINCTRL_PFC_R8A7795 be renamed to
> CONFIG_PINCTRL_PFC_R8A77951?
I think the current implementation (CONFIG_PINCTRL_PFC_R8A7795 only) is OK
because the hardware document doesn't mention about R8A77950.
> This patch series is based on renesas-drivers-2019-10-01-v5.4-rc1). For
> your convenience, it is available in the topic/r8a77961-v1 branch of my
> renesas-drivers git repository at
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
I reviewed the patch series and seems good to me after updated a few things
(add the board part number and rename R8A7796 to R8A77960). So,
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
And, I tested on the my environment. So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-10-11 8:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:23 [PATCH/RFC 00/19] arm64: dts: renesas: Initial support for R-Car M3-W+ Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 01/19] dt-bindings: arm: renesas: Document R-Car M3-W+ SoC DT bindings Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 02/19] dt-bindings: arm: renesas: Add Salvator-XS board with R-Car M3-W+ Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 03/19] dt-bindings: clock: renesas: cpg-mssr: Document r8a77961 support Geert Uytterhoeven
2019-10-14 18:45 ` Eugeniu Rosca
2019-10-16 8:35 ` Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 04/19] dt-bindings: pinctrl: sh-pfc: " Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 05/19] dt-bindings: power: rcar-sysc: " Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 06/19] dt-bindings: reset: rcar-rst: " Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 07/19] dt-bindings: serial: sh-sci: Document r8a77961 bindings Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 08/19] dt-bindings: power: Add r8a77961 SYSC power domain definitions Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 09/19] dt-bindings: clock: Add r8a77961 CPG Core Clock Definitions Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 10/19] soc: renesas: Add R8A77961 config option Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 11/19] soc: renesas: Identify R-Car M3-W+ Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 12/19] soc: renesas: rcar-sysc: Add R8A77961 support Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 13/19] soc: renesas: rcar-rst: Add support for R-Car M3-W+ Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 14/19] clk: renesas: r8a7796: Add R8A77961 CPG/MSSR support Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 15/19] pinctrl: sh-pfc: r8a7796: Add R8A77961 PFC support Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 16/19] arm64: dts: renesas: Add Renesas R8A77961 SoC support Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 17/19] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-W+ Geert Uytterhoeven
2019-10-14 17:57 ` Eugeniu Rosca
2019-10-16 8:54 ` Geert Uytterhoeven
2019-10-16 11:23 ` Eugeniu Rosca
2019-10-07 10:23 ` [PATCH/RFC 18/19] arm64: defconfig: Enable R8A77961 SoC Geert Uytterhoeven
2019-10-07 10:23 ` [PATCH/RFC 19/19] [LOCAL] arm64: renesas_defconfig: " Geert Uytterhoeven
2019-10-11 8:31 ` Yoshihiro Shimoda [this message]
2019-10-14 19:58 ` [PATCH/RFC 00/19] arm64: dts: renesas: Initial support for R-Car M3-W+ Eugeniu Rosca
2019-10-16 8:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB45444F8B8EEB971FA61D853BD8970@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=erosca@DE.ADIT-JV.COM \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).