From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] thermal: rcar_gen3_thermal: Generate interrupt when temperature changes
Date: Thu, 13 Feb 2020 08:19:25 +0000 [thread overview]
Message-ID: <TYAPR01MB4544B49ADC69B7B14B250E43D81A0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20200212224917.737314-1-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas-san,
> From: Niklas Söderlund, Sent: Thursday, February 13, 2020 7:49 AM
>
> The desired behavior of the driver is to generate an interrupt and call
> thermal_zone_device_update() as soon as the temperature have changed
> more then one degree.
>
> When the set_trips operation was implemented it was believed that the
> trip window set by the framework would move around the current
> temperature and the hysteresis value described in devicetree. The
> behavior of the framework is however to set a window based on the trip
> points described in devicetree.
>
> Remove the set_trips operation which was not used correctly and update
> the temperatures that triggers interrupts directly from the interrupt
> handler.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2020-02-13 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 22:49 [PATCH] thermal: rcar_gen3_thermal: Generate interrupt when temperature changes Niklas Söderlund
2020-02-13 8:19 ` Yoshihiro Shimoda [this message]
2020-02-26 9:05 ` Kieran Bingham
2020-02-26 11:24 ` Niklas Söderlund
2020-02-26 11:35 ` Kieran Bingham
2020-02-26 11:55 ` Niklas Söderlund
2020-02-26 11:41 ` Daniel Lezcano
2020-02-26 11:44 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544B49ADC69B7B14B250E43D81A0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).