From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux@prisktech.co.nz" <linux@prisktech.co.nz>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3] usb: host: ehci-platform: add a quirk to avoid stuck
Date: Mon, 27 Jan 2020 08:08:26 +0000 [thread overview]
Message-ID: <TYAPR01MB4544DA234E38453AE84B4F24D80B0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.2001241012160.1610-100000@iolanthe.rowland.org>
Hi Alan,
Thank you for your review!
> From: Alan Stern, Sent: Saturday, January 25, 2020 12:18 AM
<snip>
> > diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
> > index a15ce99..0ebfa74 100644
> > --- a/include/linux/usb/ehci_def.h
> > +++ b/include/linux/usb/ehci_def.h
> > @@ -150,6 +150,7 @@ struct ehci_regs {
> > #define PORT_LED_MASK (3<<14)
> > #define PORT_OWNER (1<<13) /* true: companion hc owns this port */
> > #define PORT_POWER (1<<12) /* true: has power (see PPC) */
> > +#define PORT_LS_MASK (3<<10) /* USB 1.1 device */
>
> The comment should say: /* Link status (SE0, K, or J) */
Oops. I'll fix it.
> > #define PORT_USB11(x) (((x)&(3<<10)) == (1<<10)) /* USB 1.1 device */
> > /* 11:10 for detecting lowspeed devices (reset vs release ownership) */
>
> You can remove this comment now. Since there is an actual macro for
> bits 11:10, we don't need a separate comment saying what they are.
I got it. I'll remove the "/* 11:10 for ..." comment on v4 patch.
Best regards,
Yoshihiro Shimoda
> Alan Stern
>
> > /* 9 reserved */
prev parent reply other threads:[~2020-01-27 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 4:42 [PATCH v3] usb: host: ehci-platform: add a quirk to avoid stuck Yoshihiro Shimoda
2020-01-24 15:18 ` Alan Stern
2020-01-27 8:08 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544DA234E38453AE84B4F24D80B0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).