Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Peter Rosin <peda@axentia.se>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: RE: [PATCH v3 5/7] drm/panel: panel-simple: Add connector type for etm0700g0dh6
Date: Fri, 8 Nov 2019 09:51:04 +0000
Message-ID: <TYXPR01MB1775B15EDC05B551A778B7A1C07B0@TYXPR01MB1775.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191107204846.GQ24983@pendragon.ideasonboard.com>

Hi Laurent,


Thank you for your feedback!

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 07 November 2019 20:49
> Subject: Re: [PATCH v3 5/7] drm/panel: panel-simple: Add connector type for etm0700g0dh6
> 
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Thu, Nov 07, 2019 at 08:11:01PM +0000, Fabrizio Castro wrote:
> > Add connector type for the etm0700g0dh6 from Emerging Display
> > Technologies (EDT).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > v2->v3:
> > * New patch
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 5d48768..82065ff 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1342,6 +1342,7 @@ static const struct panel_desc edt_etm0700g0dh6 = {
> >  	},
> >  	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> >  	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> > +	.connector_type = DRM_MODE_CONNECTOR_PARALLEL,
> 
> I still think we should have a DRM_MODE_CONNECTOR_PANEL, but regardless,
> this panel seems to match DRM_MODE_CONNECTOR_DPI.

Thank you! I wasn't really sure about which definition to pick, DRM_MODE_CONNECTOR_DPI
will surely work just fine.

Thanks,
Fab

> 
> >  };
> >
> >  static const struct panel_desc edt_etm0700g0bdh6 = {
> 
> --
> Regards,
> 
> Laurent Pinchart

  reply index

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:10 [PATCH v3 0/7] Add LCD panel support to iwg20d Fabrizio Castro
2019-11-07 20:10 ` [PATCH v3 1/7] dt-bindings: display: bridge: Convert lvds-transmitter binding to json-schema Fabrizio Castro
2019-11-07 20:20   ` Laurent Pinchart
2019-11-08  9:15     ` Fabrizio Castro
2019-11-08 10:54       ` Laurent Pinchart
2019-11-07 20:10 ` [PATCH v3 2/7] drm/bridge: Repurpose lvds-encoder.c Fabrizio Castro
2019-11-07 20:34   ` Laurent Pinchart
2019-11-08  9:22     ` Fabrizio Castro
2019-11-08  9:39       ` Jacopo Mondi
2019-11-08 11:06         ` Laurent Pinchart
2019-11-08 11:37           ` Jacopo Mondi
2019-11-08 11:40             ` Laurent Pinchart
2019-11-08 11:02       ` Laurent Pinchart
2019-11-07 20:10 ` [PATCH v3 3/7] dt-bindings: display: bridge: Repurpose lvds-encoder Fabrizio Castro
2019-11-07 20:38   ` Laurent Pinchart
2019-11-08  9:26     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 4/7] drm: Define DRM_MODE_CONNECTOR_PARALLEL Fabrizio Castro
2019-11-07 20:46   ` Laurent Pinchart
2019-11-08  9:32     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 5/7] drm/panel: panel-simple: Add connector type for etm0700g0dh6 Fabrizio Castro
2019-11-07 20:48   ` Laurent Pinchart
2019-11-08  9:51     ` Fabrizio Castro [this message]
2019-11-07 20:11 ` [PATCH v3 6/7] ARM: dts: iwg20d-q7-common: Add LCD support Fabrizio Castro
2019-11-07 20:55   ` Laurent Pinchart
2019-11-08 12:02     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 7/7] ARM: shmobile_defconfig: Enable support for panels from EDT Fabrizio Castro
2019-11-07 20:56   ` Laurent Pinchart
2019-11-08  8:38     ` Geert Uytterhoeven

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYXPR01MB1775B15EDC05B551A778B7A1C07B0@TYXPR01MB1775.jpnprd01.prod.outlook.com \
    --to=fabrizio.castro@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git