From: Wolfram Sang <wsa@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] ARM: dts: lager: Configure pull-up for SOFT_SW GPIO keys
Date: Tue, 25 May 2021 09:17:55 +0200 [thread overview]
Message-ID: <YKykoyZC+MG9HT/7@ninjato> (raw)
In-Reply-To: <9fae3c0c2c0000f6b43c9ce87fe64a594b30a7da.1619785905.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Fri, Apr 30, 2021 at 03:10:52PM +0200, Geert Uytterhoeven wrote:
> The GPIO pins connected to the 4 Software Switches (SW2) do not have
> external pull-up resistors, but rely on internal pull-ups being enabled.
> Fortunately this is satisfied by the initial state of these pins.
>
> Make this explicit by enabling bias-pull-up, to remove the dependency on
> initial state and/or boot loader configuration.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Works fine on my Lager board:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-25 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 13:10 [PATCH 0/5] ARM: dts: rcar2: Configure pull up for GPIO keys Geert Uytterhoeven
2021-04-30 13:10 ` [PATCH 1/5] ARM: dts: koelsch: Rename sw2 to keyboard Geert Uytterhoeven
2021-05-01 7:10 ` Niklas Söderlund
2021-04-30 13:10 ` [PATCH 2/5] ARM: dts: lager: Configure pull-up for SOFT_SW GPIO keys Geert Uytterhoeven
2021-05-25 7:17 ` Wolfram Sang [this message]
2021-04-30 13:10 ` [PATCH 3/5] ARM: dts: blanche: Configure pull-up for SOFT_SW and SW25 " Geert Uytterhoeven
2021-04-30 13:10 ` [PATCH 4/5] ARM: dts: gose: Configure pull-up for SOFT_SW " Geert Uytterhoeven
2021-04-30 13:10 ` [PATCH 5/5] ARM: dts: silk: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKykoyZC+MG9HT/7@ninjato \
--to=wsa@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).