From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20118C48BCF for ; Sun, 13 Jun 2021 01:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A4061076 for ; Sun, 13 Jun 2021 01:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbhFMBPw (ORCPT ); Sat, 12 Jun 2021 21:15:52 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38506 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbhFMBPw (ORCPT ); Sat, 12 Jun 2021 21:15:52 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BE2EE436; Sun, 13 Jun 2021 03:13:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623546830; bh=E4Gc/QsUaHVbAbV+RVx7BikI//M8UMAmG7NKfGiSVII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iacO8BE2s7wefwqrLKy6Cg31XiRAO/rm4eGvTcvQujm1aQyPekiyUWNg9JkwQjy0N L+EEvsb0eOPl7Q+6H70VCfEm6ry38Jb75AilAhit/ef2SBEmm/Ks3x1l2fXlYTqxCH 1lI0LBLIWEuUEQ8gRFgslM07n2VLIOagSqNYLEmE= Date: Sun, 13 Jun 2021 04:13:30 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Magnus Damm , Rob Herring , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 01/14] dt-bindings: arm: renesas: Document R-Car H3e-2G and M3e-2G SoCs and boards Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 10, 2021 at 11:37:14AM +0200, Geert Uytterhoeven wrote: > Document the compatible values for the R-Car H3e-2G (R8A779M1) and > M3e-2G (R8A779M3) SoCs. These are different gradings of the R-Car H3 > ES3.0 (R8A77951) and M3-W+ (R8A77961) SoCs. > > All R-Car Gen3e on-SoC devices are identical to the devices on the > corresponding R-Car Gen3 SoCs, and thus just use the compatible values > for the latter. The root compatible properties do gain an additional > value, to sort out integration issues if they ever arise. > > Document the use of these SoCs on the Salvator-XS and ULCB (with and > without Kingfisher) development boards. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart (Copying a comment from another e-mail) I however wonder if we haven't messed up the board compatible strings somehow (unrelated to this patch). Aren't compatible strings supposed to be ordered from most specific to most generic, with a more specific compatible string being a strict subset of a more generic string ? Looking at, for example, compatible = "renesas,salvator-xs", "renesas,r8a779m1", "renesas,r8a7795"; the rule is upheld by renesas,r8a779m1 being a subset of the more generic renesas,r8a7795, but that's not the case for renesas,salvator-xs. > --- > .../devicetree/bindings/arm/renesas.yaml | 50 +++++++++++++++---- > 1 file changed, 39 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > index 5fd0696a9f91f383..a01dd064bf16632a 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -238,17 +238,29 @@ properties: > - const: renesas,r8a77961 > > - description: Kingfisher (SBEV-RCAR-KF-M03) > - items: > - - const: shimafuji,kingfisher > - - enum: > - - renesas,h3ulcb > - - renesas,m3ulcb > - - renesas,m3nulcb > - - enum: > - - renesas,r8a7795 > - - renesas,r8a7796 > - - renesas,r8a77961 > - - renesas,r8a77965 > + oneOf: > + - items: > + - const: shimafuji,kingfisher > + - enum: > + - renesas,h3ulcb > + - renesas,m3ulcb > + - renesas,m3nulcb > + - enum: > + - renesas,r8a7795 > + - renesas,r8a7796 > + - renesas,r8a77961 > + - renesas,r8a77965 > + - items: > + - const: shimafuji,kingfisher > + - enum: > + - renesas,h3ulcb > + - renesas,m3ulcb > + - enum: > + - renesas,r8a779m1 > + - renesas,r8a779m3 > + - enum: > + - renesas,r8a7795 > + - renesas,r8a77961 > > - description: R-Car M3-N (R8A77965) > items: > @@ -296,6 +308,22 @@ properties: > - const: renesas,falcon-cpu > - const: renesas,r8a779a0 > > + - description: R-Car H3e-2G (R8A779M1) > + items: > + - enum: > + - renesas,h3ulcb # H3ULCB (R-Car Starter Kit Premier) > + - renesas,salvator-xs # Salvator-XS (Salvator-X 2nd version) > + - const: renesas,r8a779m1 > + - const: renesas,r8a7795 > + > + - description: R-Car M3e-2G (R8A779M3) > + items: > + - enum: > + - renesas,m3ulcb # M3ULCB (R-Car Starter Kit Pro) > + - renesas,salvator-xs # Salvator-XS (Salvator-X 2nd version) > + - const: renesas,r8a779m3 > + - const: renesas,r8a77961 > + > - description: RZ/N1D (R9A06G032) > items: > - enum: -- Regards, Laurent Pinchart