From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order
Date: Wed, 23 Jun 2021 20:13:17 +0200 [thread overview]
Message-ID: <YNN5vXDKBTurLmQK@oden.dyn.berto.se> (raw)
In-Reply-To: <8d68a7ce449aaf90a88e69397dbe0e9c467d5726.1624460175.git.geert+renesas@glider.be>
Hello,
On 2021-06-23 16:59:25 +0200, Geert Uytterhoeven wrote:
> The thermal node was inserted at the wrong place, breaking sort order
> (sort by unit address, but group nodes of the same type).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Probably it was my fault, not Niklas' ;-)
Most likely my fault, happy order is restored.
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> To be queued in renesas-devel for v5.15.
>
> arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 26 +++++++++++------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> index a7dfade1801a87db..3676b2bd3d646cdb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -327,6 +327,19 @@ sysc: system-controller@e6180000 {
> #power-domain-cells = <1>;
> };
>
> + tsc: thermal@e6190000 {
> + compatible = "renesas,r8a779a0-thermal";
> + reg = <0 0xe6190000 0 0x200>,
> + <0 0xe6198000 0 0x200>,
> + <0 0xe61a0000 0 0x200>,
> + <0 0xe61a8000 0 0x200>,
> + <0 0xe61b0000 0 0x200>;
> + clocks = <&cpg CPG_MOD 919>;
> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> + resets = <&cpg 919>;
> + #thermal-sensor-cells = <1>;
> + };
> +
> tmu0: timer@e61e0000 {
> compatible = "renesas,tmu-r8a779a0", "renesas,tmu";
> reg = <0 0xe61e0000 0 0x30>;
> @@ -392,19 +405,6 @@ tmu4: timer@ffc00000 {
> status = "disabled";
> };
>
> - tsc: thermal@e6190000 {
> - compatible = "renesas,r8a779a0-thermal";
> - reg = <0 0xe6190000 0 0x200>,
> - <0 0xe6198000 0 0x200>,
> - <0 0xe61a0000 0 0x200>,
> - <0 0xe61a8000 0 0x200>,
> - <0 0xe61b0000 0 0x200>;
> - clocks = <&cpg CPG_MOD 919>;
> - power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> - resets = <&cpg 919>;
> - #thermal-sensor-cells = <1>;
> - };
> -
> i2c0: i2c@e6500000 {
> compatible = "renesas,i2c-r8a779a0",
> "renesas,rcar-gen3-i2c";
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2021-06-23 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:59 [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order Geert Uytterhoeven
2021-06-23 18:13 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNN5vXDKBTurLmQK@oden.dyn.berto.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).