linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
	ulf.hansson@linaro.org
Subject: Re: [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit
Date: Wed, 30 Jun 2021 06:44:52 +0200	[thread overview]
Message-ID: <YNv2xNjvU6Ptddjq@ninjato> (raw)
In-Reply-To: <20210514155318.16812-1-uli+renesas@fpond.eu>

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

On Fri, May 14, 2021 at 05:53:18PM +0200, Ulrich Hecht wrote:
> The TMIO core sets a very low latency limit (100 us), but when using R-Car
> SDHI hosts with SD cards, I have observed typical latencies of around 20-30
> ms. This prevents runtime PM from working properly, and the devices remain
> on continuously.
> 
> This patch sets the default latency limit to 100 ms to avoid that.
> 
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>

Ulrich is right that the tuning error is just a cosmetic problem
revealed by this patch and not really a regression. We are working on
fixing this cosmetic problem. However, this patch is good as is and we
finally have RPM working for SDHI with it. I tested RPM and
suspend/resume and all worked nicely:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-06-30  4:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 15:53 [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit Ulrich Hecht
2021-05-19 14:25 ` Wolfram Sang
2021-06-02 15:40   ` Ulrich Hecht
2021-06-18  8:17     ` Wolfram Sang
2021-06-18 10:40       ` Wolfram Sang
2021-06-30  4:44 ` Wolfram Sang [this message]
2021-07-30 15:28 ` Wolfram Sang
2021-08-02  5:34   ` Yoshihiro Shimoda
2021-08-02 11:18     ` Ulrich Hecht
2021-08-03 11:16       ` Yoshihiro Shimoda
2021-08-04  5:29         ` Yoshihiro Shimoda
2021-08-04 16:17           ` Ulrich Hecht
2021-08-02 12:53     ` Wolfram Sang
2021-08-03 11:16       ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNv2xNjvU6Ptddjq@ninjato \
    --to=wsa@kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=uli+renesas@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).