linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
@ 2021-07-12 10:16 Geert Uytterhoeven
  2021-07-12 11:24 ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-07-12 10:16 UTC (permalink / raw)
  To: Magnus Damm, Laurent Pinchart, Kieran Bingham
  Cc: linux-renesas-soc, linux-arm-kernel, Geert Uytterhoeven

As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
be considered unneeded for systems where graphics is provided by a DRM
driver, R-Mobile A1 still relies on a frame buffer device driver for
graphics support.

Restore support for graphics on R-Mobile A1 and graphical consoles on
DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
Renesas ARM systems.

Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued as a fix for v5.14.
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 66c8b0980a0a744d..d9a27e4e09140b43 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -135,6 +135,7 @@ CONFIG_DRM_SII902X=y
 CONFIG_DRM_SIMPLE_BRIDGE=y
 CONFIG_DRM_I2C_ADV7511=y
 CONFIG_DRM_I2C_ADV7511_AUDIO=y
+CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_BACKLIGHT_PWM=y
 CONFIG_BACKLIGHT_AS3711=y
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
  2021-07-12 10:16 [PATCH] ARM: shmobile: defconfig: Restore graphical consoles Geert Uytterhoeven
@ 2021-07-12 11:24 ` Laurent Pinchart
  2021-07-12 11:35   ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2021-07-12 11:24 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Kieran Bingham, linux-renesas-soc, linux-arm-kernel

Hi Geert,

Thank you for the patch.

On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
> be considered unneeded for systems where graphics is provided by a DRM
> driver, R-Mobile A1 still relies on a frame buffer device driver for
> graphics support.
> 
> Restore support for graphics on R-Mobile A1 and graphical consoles on
> DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> Renesas ARM systems.

Does anyone still care about the Armadillo board ?

This being said, I think CONFIG_FB should be added , but for a different
reason. There's no KMS console driver, so the only option we have today,
even when a KMS driver is available, is to go through FBDEV emulation,
which requires CONFIG_FB to be enabled.

> Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued as a fix for v5.14.
> ---
>  arch/arm/configs/shmobile_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 66c8b0980a0a744d..d9a27e4e09140b43 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -135,6 +135,7 @@ CONFIG_DRM_SII902X=y
>  CONFIG_DRM_SIMPLE_BRIDGE=y
>  CONFIG_DRM_I2C_ADV7511=y
>  CONFIG_DRM_I2C_ADV7511_AUDIO=y
> +CONFIG_FB=y
>  CONFIG_FB_SH_MOBILE_LCDC=y
>  CONFIG_BACKLIGHT_PWM=y
>  CONFIG_BACKLIGHT_AS3711=y

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
  2021-07-12 11:24 ` Laurent Pinchart
@ 2021-07-12 11:35   ` Geert Uytterhoeven
  2021-07-12 11:43     ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-07-12 11:35 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Magnus Damm, Kieran Bingham, Linux-Renesas, Linux ARM

Hi Laurent,

On Mon, Jul 12, 2021 at 1:25 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
> > be considered unneeded for systems where graphics is provided by a DRM
> > driver, R-Mobile A1 still relies on a frame buffer device driver for
> > graphics support.
> >
> > Restore support for graphics on R-Mobile A1 and graphical consoles on
> > DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> > Renesas ARM systems.
>
> Does anyone still care about the Armadillo board ?

I do. It's my only Renesas board with graphical output ;-)

> This being said, I think CONFIG_FB should be added , but for a different
> reason. There's no KMS console driver, so the only option we have today,
> even when a KMS driver is available, is to go through FBDEV emulation,
> which requires CONFIG_FB to be enabled.

That's covered by "Restore [...] graphical consoles on DRM-based
systems", right?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
  2021-07-12 11:35   ` Geert Uytterhoeven
@ 2021-07-12 11:43     ` Laurent Pinchart
  2021-07-12 11:49       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2021-07-12 11:43 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, Kieran Bingham, Linux-Renesas, Linux ARM

Hi Geert,

On Mon, Jul 12, 2021 at 01:35:34PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 12, 2021 at 1:25 PM Laurent Pinchart wrote:
> > On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> > > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
> > > be considered unneeded for systems where graphics is provided by a DRM
> > > driver, R-Mobile A1 still relies on a frame buffer device driver for
> > > graphics support.
> > >
> > > Restore support for graphics on R-Mobile A1 and graphical consoles on
> > > DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> > > Renesas ARM systems.
> >
> > Does anyone still care about the Armadillo board ?
> 
> I do. It's my only Renesas board with graphical output ;-)

I recommend a VGA or HDMI monitor :-) The sh-mobile-lcdcfb driver is
unmaintained. If nostalgia is a big enough drive factor, you could try
converting R-Mobile A1 to the shmob-drm driver :-)

> > This being said, I think CONFIG_FB should be added , but for a different
> > reason. There's no KMS console driver, so the only option we have today,
> > even when a KMS driver is available, is to go through FBDEV emulation,
> > which requires CONFIG_FB to be enabled.
> 
> That's covered by "Restore [...] graphical consoles on DRM-based
> systems", right?

I had read the commit message as implying that a graphical console can
be available without FB when a KMS driver is available.

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
  2021-07-12 11:43     ` Laurent Pinchart
@ 2021-07-12 11:49       ` Geert Uytterhoeven
  2021-07-12 12:04         ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-07-12 11:49 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Magnus Damm, Kieran Bingham, Linux-Renesas, Linux ARM

Hi Laurent,

On Mon, Jul 12, 2021 at 1:44 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jul 12, 2021 at 01:35:34PM +0200, Geert Uytterhoeven wrote:
> > On Mon, Jul 12, 2021 at 1:25 PM Laurent Pinchart wrote:
> > > On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> > > > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > > > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
> > > > be considered unneeded for systems where graphics is provided by a DRM
> > > > driver, R-Mobile A1 still relies on a frame buffer device driver for
> > > > graphics support.
> > > >
> > > > Restore support for graphics on R-Mobile A1 and graphical consoles on
> > > > DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> > > > Renesas ARM systems.
> > >
> > > Does anyone still care about the Armadillo board ?
> >
> > I do. It's my only Renesas board with graphical output ;-)
>
> I recommend a VGA or HDMI monitor :-) The sh-mobile-lcdcfb driver is
> unmaintained. If nostalgia is a big enough drive factor, you could try
> converting R-Mobile A1 to the shmob-drm driver :-)

I'll do so as soon as drivers/gpu/drm/shmobile has gained DT support...

> > > This being said, I think CONFIG_FB should be added , but for a different
> > > reason. There's no KMS console driver, so the only option we have today,
> > > even when a KMS driver is available, is to go through FBDEV emulation,
> > > which requires CONFIG_FB to be enabled.
> >
> > That's covered by "Restore [...] graphical consoles on DRM-based
> > systems", right?
>
> I had read the commit message as implying that a graphical console can
> be available without FB when a KMS driver is available.

I was wondering if you still wanted a graphical console on top of a
DRM driver...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
  2021-07-12 11:49       ` Geert Uytterhoeven
@ 2021-07-12 12:04         ` Laurent Pinchart
  0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2021-07-12 12:04 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, Kieran Bingham, Linux-Renesas, Linux ARM

Hi Geert,

On Mon, Jul 12, 2021 at 01:49:26PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 12, 2021 at 1:44 PM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Mon, Jul 12, 2021 at 01:35:34PM +0200, Geert Uytterhoeven wrote:
> > > On Mon, Jul 12, 2021 at 1:25 PM Laurent Pinchart wrote:
> > > > On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> > > > > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > > > > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.  While CONFIG_FB may
> > > > > be considered unneeded for systems where graphics is provided by a DRM
> > > > > driver, R-Mobile A1 still relies on a frame buffer device driver for
> > > > > graphics support.
> > > > >
> > > > > Restore support for graphics on R-Mobile A1 and graphical consoles on
> > > > > DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> > > > > Renesas ARM systems.
> > > >
> > > > Does anyone still care about the Armadillo board ?
> > >
> > > I do. It's my only Renesas board with graphical output ;-)
> >
> > I recommend a VGA or HDMI monitor :-) The sh-mobile-lcdcfb driver is
> > unmaintained. If nostalgia is a big enough drive factor, you could try
> > converting R-Mobile A1 to the shmob-drm driver :-)
> 
> I'll do so as soon as drivers/gpu/drm/shmobile has gained DT support...

The fbdev driver doesn't have DT support either. And patches are welcome
for shmob-drm ;-)

> > > > This being said, I think CONFIG_FB should be added , but for a different
> > > > reason. There's no KMS console driver, so the only option we have today,
> > > > even when a KMS driver is available, is to go through FBDEV emulation,
> > > > which requires CONFIG_FB to be enabled.
> > >
> > > That's covered by "Restore [...] graphical consoles on DRM-based
> > > systems", right?
> >
> > I had read the commit message as implying that a graphical console can
> > be available without FB when a KMS driver is available.
> 
> I was wondering if you still wanted a graphical console on top of a
> DRM driver...

Same answer for DRM and FBDEV, it's about whether you want a graphical
console or not. The underlying API doesn't matter (I wish we had a
kmscon).

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-12 12:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 10:16 [PATCH] ARM: shmobile: defconfig: Restore graphical consoles Geert Uytterhoeven
2021-07-12 11:24 ` Laurent Pinchart
2021-07-12 11:35   ` Geert Uytterhoeven
2021-07-12 11:43     ` Laurent Pinchart
2021-07-12 11:49       ` Geert Uytterhoeven
2021-07-12 12:04         ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).