From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v3 2/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper
Date: Sun, 22 Aug 2021 03:01:27 +0300 [thread overview]
Message-ID: <YSGT19Be+KtOnVoZ@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdVd75h7qCxqfQ4MCoUwEiTJktTYykZgnWy7zFgxuHXmAg@mail.gmail.com>
Hi Geert,
On Tue, Aug 10, 2021 at 05:51:57PM +0200, Geert Uytterhoeven wrote:
> On Tue, Aug 10, 2021 at 5:47 PM Geert Uytterhoeven wrote:
> > On Thu, May 20, 2021 at 8:51 AM Laurent Pinchart wrote:
> > > Replace the manual panel handling with usage of the DRM panel bridge
> > > helper. This simplifies the driver, and brings support for
> > > DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > Thanks for your patch, which is now commit e9e056949c927e5b ("drm:
> > rcar-du: lvds: Convert to DRM panel bridge helper") in drm-next.
> >
> > This causes the following scary messages in the kernel log on Ebisu-4D:
> >
> > [drm:drm_bridge_attach] *ERROR* failed to attach bridge
>
> > Reverting this commit fixes the issue.
>
> Oops, that's not true (should not write tentative messages while booting
> a test kernel, and press send without checking first ;-)
>
> Reverting the commit doesn't seem to make a difference.
> But the parent 5bcc48395b9f35da ("drm: bridge: dw-hdmi: Attach to
> next bridge if available") of the bad commit is fine.
Thanks for the report. I've reproduced this and will send a fix shortly.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-08-22 0:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 6:50 [PATCH v3 0/4] Converter R-Car DU to the DRM bridge connector helper Laurent Pinchart
2021-05-20 6:50 ` [PATCH v3 1/4] drm: bridge: dw-hdmi: Attach to next bridge if available Laurent Pinchart
2021-06-22 22:07 ` Kieran Bingham
2021-05-20 6:50 ` [PATCH v3 2/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper Laurent Pinchart
2021-06-22 22:10 ` Kieran Bingham
2021-08-10 15:47 ` Geert Uytterhoeven
2021-08-10 15:51 ` Geert Uytterhoeven
2021-08-22 0:01 ` Laurent Pinchart [this message]
2021-05-20 6:50 ` [PATCH v3 3/4] drm: rcar-du: dw-hdmi: Set output port number Laurent Pinchart
2021-06-22 22:14 ` Kieran Bingham
2021-05-20 6:50 ` [PATCH v3 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper Laurent Pinchart
2021-06-22 22:17 ` Kieran Bingham
2021-06-22 21:53 ` [PATCH v3 0/4] Converter R-Car DU to the DRM bridge connector helper Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSGT19Be+KtOnVoZ@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).