From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB04C433FE for ; Wed, 22 Sep 2021 17:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E575F61131 for ; Wed, 22 Sep 2021 17:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236893AbhIVRcZ (ORCPT ); Wed, 22 Sep 2021 13:32:25 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54064 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236854AbhIVRcZ (ORCPT ); Wed, 22 Sep 2021 13:32:25 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 808B3F1; Wed, 22 Sep 2021 19:30:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632331853; bh=2FNb00TpU21YxWc+F6Cr2WPYvozGyOiwqstQ7td4r68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sx0jKva1ksc4oLJa5BlJHZyhXSORVdBcUgXuyYnwz+NbFy7Omu8/YPyZDQJSLCF/0 VVnbr58peOJkjI86T+D4t825sGXwvaKr75VTclnbyw1jKc1svT7WmYDnxAHZE4HGKA 2TOYdY2AaApbOMP6Nj3WQtYu6JC9cJZeAKfs186I= Date: Wed, 22 Sep 2021 20:30:51 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham , David Airlie , Daniel Vetter , "open list:DRM DRIVERS FOR RENESAS" , open list Subject: Re: [PATCH v2 3/5] drm: rcar-du: Fix DIDSR field name Message-ID: References: <20210901234907.1608896-1-kieran.bingham@ideasonboard.com> <20210901234907.1608896-4-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210901234907.1608896-4-kieran.bingham@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Kieran, Thank you for the patch. On Thu, Sep 02, 2021 at 12:49:05AM +0100, Kieran Bingham wrote: > The DIDSR fields named LDCS were incorrectly defined as LCDS. > Both the Gen2 and Gen3 documentation refer to the fields as the "LVDS > Dot Clock Select". > > Correct the definitions. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > v2: > - New patch > > drivers/gpu/drm/rcar-du/rcar_du_group.c | 4 ++-- > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_group.c b/drivers/gpu/drm/rcar-du/rcar_du_group.c > index 88a783ceb3e9..a984eef265d2 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_group.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_group.c > @@ -122,10 +122,10 @@ static void rcar_du_group_setup_didsr(struct rcar_du_group *rgrp) > didsr = DIDSR_CODE; > for (i = 0; i < num_crtcs; ++i, ++rcrtc) { > if (rcdu->info->lvds_clk_mask & BIT(rcrtc->index)) > - didsr |= DIDSR_LCDS_LVDS0(i) > + didsr |= DIDSR_LDCS_LVDS0(i) > | DIDSR_PDCS_CLK(i, 0); > else > - didsr |= DIDSR_LCDS_DCLKIN(i) > + didsr |= DIDSR_LDCS_DCLKIN(i) > | DIDSR_PDCS_CLK(i, 0); > } > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_regs.h b/drivers/gpu/drm/rcar-du/rcar_du_regs.h > index fb9964949368..fb7c467aa484 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_regs.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_regs.h > @@ -257,10 +257,10 @@ > > #define DIDSR 0x20028 > #define DIDSR_CODE (0x7790 << 16) > -#define DIDSR_LCDS_DCLKIN(n) (0 << (8 + (n) * 2)) > -#define DIDSR_LCDS_LVDS0(n) (2 << (8 + (n) * 2)) > -#define DIDSR_LCDS_LVDS1(n) (3 << (8 + (n) * 2)) > -#define DIDSR_LCDS_MASK(n) (3 << (8 + (n) * 2)) > +#define DIDSR_LDCS_DCLKIN(n) (0 << (8 + (n) * 2)) > +#define DIDSR_LDCS_LVDS0(n) (2 << (8 + (n) * 2)) > +#define DIDSR_LDCS_LVDS1(n) (3 << (8 + (n) * 2)) > +#define DIDSR_LDCS_MASK(n) (3 << (8 + (n) * 2)) > #define DIDSR_PDCS_CLK(n, clk) (clk << ((n) * 2)) > #define DIDSR_PDCS_MASK(n) (3 << ((n) * 2)) > -- Regards, Laurent Pinchart