From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v2] media: rcar-vin: add GREY format
Date: Wed, 29 Sep 2021 16:53:50 +0200 [thread overview]
Message-ID: <YVR9/iQIGp/T2ymx@oden.dyn.berto.se> (raw)
In-Reply-To: <20210924124315.26164-1-nikita.yoush@cogentembedded.com>
Hi Vladimir,
Thanks for your work.
On 2021-09-24 15:43:17 +0300, Nikita Yushchenko wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> This adds support for MEDIA_BUS_FMT_Y8_1X8 input and V4L2_PIX_FMT_GREY
> output format.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes from v1:
> - fix coding style issue
>
> drivers/media/platform/rcar-vin/rcar-dma.c | 15 +++++++++++++++
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 ++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c
> index f5f722ab1d4e..4d0d95cf4c5f 100644
> --- a/drivers/media/platform/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/rcar-vin/rcar-dma.c
> @@ -114,6 +114,7 @@
> /* Video n Data Mode Register bits */
> #define VNDMR_A8BIT(n) (((n) & 0xff) << 24)
> #define VNDMR_A8BIT_MASK (0xff << 24)
> +#define VNDMR_YMODE_Y8 (1 << 12)
> #define VNDMR_EXRGB (1 << 8)
> #define VNDMR_BPSM (1 << 4)
> #define VNDMR_ABIT (1 << 2)
> @@ -603,6 +604,7 @@ void rvin_crop_scale_comp(struct rvin_dev *vin)
> case V4L2_PIX_FMT_SGBRG8:
> case V4L2_PIX_FMT_SGRBG8:
> case V4L2_PIX_FMT_SRGGB8:
> + case V4L2_PIX_FMT_GREY:
> stride /= 2;
> break;
> default:
> @@ -695,6 +697,7 @@ static int rvin_setup(struct rvin_dev *vin)
> case MEDIA_BUS_FMT_SGBRG8_1X8:
> case MEDIA_BUS_FMT_SGRBG8_1X8:
> case MEDIA_BUS_FMT_SRGGB8_1X8:
> + case MEDIA_BUS_FMT_Y8_1X8:
> vnmc |= VNMC_INF_RAW8;
> break;
> default:
> @@ -774,6 +777,14 @@ static int rvin_setup(struct rvin_dev *vin)
> case V4L2_PIX_FMT_SRGGB8:
> dmr = 0;
> break;
> + case V4L2_PIX_FMT_GREY:
> + if (input_is_yuv) {
> + dmr = VNDMR_DTMD_YCSEP | VNDMR_YMODE_Y8;
> + output_is_yuv = true;
> + } else {
> + dmr = 0;
> + }
> + break;
> default:
> vin_err(vin, "Invalid pixelformat (0x%x)\n",
> vin->format.pixelformat);
> @@ -1145,6 +1156,10 @@ static int rvin_mc_validate_format(struct rvin_dev *vin, struct v4l2_subdev *sd,
> if (vin->format.pixelformat != V4L2_PIX_FMT_SRGGB8)
> return -EPIPE;
> break;
> + case MEDIA_BUS_FMT_Y8_1X8:
> + if (vin->format.pixelformat != V4L2_PIX_FMT_GREY)
> + return -EPIPE;
> + break;
> default:
> return -EPIPE;
> }
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> index 0d141155f0e3..bdeff51bf768 100644
> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> @@ -82,6 +82,10 @@ static const struct rvin_video_format rvin_formats[] = {
> .fourcc = V4L2_PIX_FMT_SRGGB8,
> .bpp = 1,
> },
> + {
> + .fourcc = V4L2_PIX_FMT_GREY,
> + .bpp = 1,
> + },
> };
>
> const struct rvin_video_format *rvin_format_from_pixel(struct rvin_dev *vin,
> --
> 2.30.2
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2021-09-29 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:19 [PATCH] media: rcar-vin: add support for GREY format Nikita Yushchenko
2021-09-24 10:00 ` Niklas Söderlund
2021-09-24 12:23 ` Nikita Yushchenko
2021-09-24 12:43 ` [PATCH v2] media: rcar-vin: add " Nikita Yushchenko
2021-09-29 14:53 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVR9/iQIGp/T2ymx@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).