From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH] media: v4l2-ctrls: Fix off-by-one error in integer menu control check
Date: Mon, 26 Sep 2022 19:40:39 +0300 [thread overview]
Message-ID: <YzHWB0OLLet+hgo1@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20220926163151.21445-1-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On Mon, Sep 26, 2022 at 07:31:51PM +0300, Laurent Pinchart wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> The V4L2 API defines the maximum value for an integer menu control as
> the number of elements minus one. The v4l2_ctrl_new_std_menu() validates
> this constraint with an off-by-one error. Fix it.
>
> Fixes: d1e9b7c12b74 ("[media] V4L: Add support for integer menu controls with standard menu items")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/v4l2-core/v4l2-ctrls-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c
> index 1f85828d6694..322f9f715b65 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
> @@ -1762,7 +1762,7 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_menu(struct v4l2_ctrl_handler *hdl,
> else if (type == V4L2_CTRL_TYPE_INTEGER_MENU)
> qmenu_int = v4l2_ctrl_get_int_menu(id, &qmenu_int_len);
>
> - if ((!qmenu && !qmenu_int) || (qmenu_int && max > qmenu_int_len)) {
> + if ((!qmenu && !qmenu_int) || (qmenu_int && max >= qmenu_int_len)) {
> handler_set_err(hdl, -EINVAL);
> return NULL;
> }
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2022-09-26 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 16:31 [PATCH] media: v4l2-ctrls: Fix off-by-one error in integer menu control check Laurent Pinchart
2022-09-26 16:40 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzHWB0OLLet+hgo1@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).