Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: David Lechner <david@lechnology.com>
To: Sam Ravnborg <sam@ravnborg.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	"Chris Brandt" <chris.brandt@renesas.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t
Date: Mon, 6 Jan 2020 10:47:55 -0600
Message-ID: <a324b889-4fd1-fd93-dd70-61a6a57713a1@lechnology.com> (raw)
In-Reply-To: <20200102144636.GA10075@ravnborg.org>

On 1/2/20 8:46 AM, Sam Ravnborg wrote:
> Hi Geert.
> 
> On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote:
>> Document support for the Okaya RH128128T display, which is a 128x128
>> 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver.
>>
>> ST7715R and ST7735R are very similar.  Their major difference is that
>> the former is restricted to displays of up to 132x132 pixels, while the
>> latter supports displays up to 132x162 pixels.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>   .../devicetree/bindings/display/sitronix,st7735r.txt          | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
>> index cd5c7186890a2be7..87ebdcb294e29798 100644
>> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
>> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> While touching the bindings file, can I convince you to convert it to
> meta-schema format (.yaml)?
> 
> 
>> @@ -4,7 +4,9 @@ This binding is for display panels using a Sitronix ST7735R controller in SPI
>>   mode.
>>   
>>   Required properties:
>> -- compatible:	"jianda,jd-t18003-t01", "sitronix,st7735r"
>> +- compatible:	Must be one of the following combinations:
>> +		  - "jianda,jd-t18003-t01", "sitronix,st7735r"
>> +		  - "okaya,rh128128t", "sitronix,st7715r"
> 
> It would be nice if there was a "description" for each pair of
> compatible that identified the actual panel.
> In your case "Okaya RH128128T 1.44" 128x128 TFT display"
> It can be looked up in git history - but better to have it in the
> binding file.
> 
> 	Sam
> 

It would be nice to have the Adafruit part name in here too while we
are at it. I had to dig really deep to find what the actual display
panel was.

https://www.adafruit.com/product/358
https://www.adafruit.com/product/618

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 14:12 [PATCH 0/3] drm: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-02 14:12 ` [PATCH 1/3] dt-bindings: display: sitronix,st7735r: Add Okaya rh128128t Geert Uytterhoeven
2020-01-02 14:46   ` [PATCH 1/3] dt-bindings: display: sitronix, st7735r: " Sam Ravnborg
2020-01-06 16:47     ` David Lechner [this message]
2020-01-02 14:12 ` [PATCH 2/3] drm/mipi_dbi: Add support for display offsets Geert Uytterhoeven
2020-01-05  8:46   ` Sam Ravnborg
2020-01-02 14:12 ` [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-05  9:13   ` Sam Ravnborg
2020-01-06  9:28     ` Geert Uytterhoeven
2020-01-06 17:08       ` Sam Ravnborg
2020-01-07 12:00         ` Geert Uytterhoeven
2020-01-06 17:12       ` David Lechner
2020-01-07 12:46         ` Geert Uytterhoeven

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a324b889-4fd1-fd93-dd70-61a6a57713a1@lechnology.com \
    --to=david@lechnology.com \
    --cc=airlied@linux.ie \
    --cc=chris.brandt@renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mark.rutland@arm.com \
    --cc=mripard@kernel.org \
    --cc=noralf@tronnes.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git