From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55B1C433E0 for ; Mon, 18 May 2020 08:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84F0020657 for ; Mon, 18 May 2020 08:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="Fj/ftm6q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbgERIgV (ORCPT ); Mon, 18 May 2020 04:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgERIgV (ORCPT ); Mon, 18 May 2020 04:36:21 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F193C061A0C for ; Mon, 18 May 2020 01:36:19 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id u6so8889919ljl.6 for ; Mon, 18 May 2020 01:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Th+BWkXMDcWR/K/DGtUISavi2Rg0yIxH2nGUtq0N8b8=; b=Fj/ftm6qZElHHwVFTu4fvVKu4bMhE7pXVQs0ZNoLXSnZTk6xbO/LTd1h9aBgoYB5XL 8RFqT3QbwaP2Q6LDBV0gGnI70EZAq9Ms0aAA3M/kqUlwOoe3YzFzI8mWIllXLAF55gGj xX9IzqkK4j9TaGVLiyuq6LjilX20c0gYSdpCk/pS2cA1G7b1Oou9yu4dYC3vFn3uXiDL 9iElSyG+yTbJ0E1EmbvT6MXDfBRa3kJ5euxXQKkZgUOJhH0FIT/3/9Wqgy/IiC0W2U6k r0yNA26HGVcPhVp1NMiOe5Ml4pD60FqdsgEWt+uL1TKQAyppwTpEEm98Tw5DYyt8JWpT KN5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Th+BWkXMDcWR/K/DGtUISavi2Rg0yIxH2nGUtq0N8b8=; b=LlpDykg2nza2xhEv4mzTaWMXpYVel+S27+zxs/OGTSbB3PmxWpT+k1sokB6+1Au+20 Oew+v2VvkJe7yJtxl5+eXp+OvDWrDJ/cfogRp8/qjicmDOjcRBCHMR6vip6kitqTpPMK qxuhNokR1XoLSRDH0bMEhweLDITLhavBYig+RoCe8um2gOzp+sNtTf501OBvnhbNZnZM ZDGnhC3Ao3Ki61iYvAdg+yH6agu1XXzSp6v/r1K8eQ5B6CVp7fXmfFcdTgqXOeBf2k3b 7m/i6eF2g3nX3jXe+mo3P4W3o3Bm6NKfEO+kqt8nrtPlGkNrbS78HGfCTqaHsEht5/gp fo0A== X-Gm-Message-State: AOAM530CHnfN6QBVIlQ7zhNL0eYDh5LlxNSp6+0BQUWhnG99sjCXDdQd PP8Turu6GjMnc5TH/oRAOiBA+g== X-Google-Smtp-Source: ABdhPJwAUODjte0wjN07kn09YGodWQ48GMKSNXNWXjvWzkzQCYB0H0nivV0bFcrjmutsELlHO2Botg== X-Received: by 2002:a2e:8901:: with SMTP id d1mr9958882lji.37.1589790978038; Mon, 18 May 2020 01:36:18 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:46bf:e420:f94f:d60b:efec:4413? ([2a00:1fa0:46bf:e420:f94f:d60b:efec:4413]) by smtp.gmail.com with ESMTPSA id v18sm2291121ljc.55.2020.05.18.01.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 01:36:17 -0700 (PDT) Subject: Re: [PATCH v2] ravb: On timeout disable IRQs to stop processing To: Dirk Behme , linux-renesas-soc@vger.kernel.org Cc: Shashikant.Suguni@in.bosch.com References: <20200518045452.2390-1-dirk.behme@de.bosch.com> From: Sergei Shtylyov Message-ID: Date: Mon, 18 May 2020 11:36:12 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200518045452.2390-1-dirk.behme@de.bosch.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 18.05.2020 7:54, Dirk Behme wrote: > Analyzing [1] it seems there is a race condition where ravb_start_xmit() > can be called from interrupt while tx skbuffs are being torn down in > the scheduled timeout handling. The actual timeout work is done in > ravb_tx_timeout_work() during which the tx skbuffs are torn down via > invocations of ravb_ring_free(). But there seems to be no flag to tell > the driver it is shutting down so it continues to use the ring buffer > when it should not. > > Fix this by disabling the interrupts in the timeout handler. > > [1] > > -- cut -- > ravb e6800000.ethernet ethernet: transmit timed out, status 00000000, resetting... > ravb e6800000.ethernet ethernet: failed to switch device to config mode > Unable to handle kernel NULL pointer dereference at virtual address 00000018 > Mem abort info: > Exception class = DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > Data abort info: > ISV = 0, ISS = 0x00000046 > CM = 0, WnR = 1 > user pgtable: 4k pages, 48-bit VAs, pgd = ffff80065622f000 > [0000000000000018] *pgd=00000006962a7003 > , *pud=00000006962a8003 > , *pmd=0000000000000000 > Internal error: Oops: 96000046 [#1] PREEMPT SMP > Modules linked in: > ... > Process Thread1 (pid: 3132, stack limit = 0xffff000027dd0000) > CPU: 2 PID: 3132 Comm: Thread1 Tainted: G WC 4.14.130-ltsi-g28acae87 #1 > Hardware name: Board based on r8a7796 (DT) > task: ffff80064f2aaa00 task.stack: ffff000027dd0000 > PC is at ravb_start_xmit+0x138/0x5a0 > LR is at ravb_start_xmit+0x40/0x5a0 > pc : [] lr : [] pstate: 600001c5 > sp : ffff000027dd3550 > x29: ffff000027dd3550 > x28: 0000000000000076 > x27: ffff80061035ff00 > x26: ffff000027dd3694 > x25: ffff80069624f800 > x24: ffff80069624f000 > x23: 0000000000000003 > x22: 0000000000000001 > x21: ffff80069624f000 > x20: 0000000000000000 > x19: ffff80069624f000 > x18: 0000000000000014 > x17: 0000ffff9b90ddb0 > x16: ffff00000867d07c > x15: 0000155107b31031 > x14: 000409000c000000 > x13: 0000000003000001 > x12: 0100050010000001 > x11: 0000000003000001 > x10: 0100010010000001 > x9 : 20000000000000c0 > x8 : 0000000000000000 > x7 : ffff8006656f9388 > x6 : 0000000000000002 > x5 : 0000000000000000 > x4 : ffff8006656f929c > x3 : ffff000027dd3694 > x2 : 0000000000000018 > x1 : 0000000000000000 > x0 : 0000000000000003 > Call trace: > Exception stack(0xffff000027dd3410 to 0xffff000027dd3550) > 3400: 0000000000000003 0000000000000000 > 3420: 0000000000000018 ffff000027dd3694 ffff8006656f929c 0000000000000000 > 3440: 0000000000000002 ffff8006656f9388 0000000000000000 20000000000000c0 > 3460: 0100010010000001 0000000003000001 0100050010000001 0000000003000001 > 3480: 000409000c000000 0000155107b31031 ffff00000867d07c 0000ffff9b90ddb0 > 34a0: 0000000000000014 ffff80069624f000 0000000000000000 ffff80069624f000 > 34c0: 0000000000000001 0000000000000003 ffff80069624f000 ffff80069624f800 > 34e0: ffff000027dd3694 ffff80061035ff00 0000000000000076 ffff000027dd3550 > 3500: ffff0000084d622c ffff000027dd3550 ffff0000084d6324 00000000600001c5 > 3520: ffff00000921d008 ffff8006159b0d00 0000ffffffffffff ffff0000084d622c > 3540: ffff000027dd3550 ffff0000084d6324 > [] ravb_start_xmit+0x138/0x5a0 > [] dev_hard_start_xmit+0xa8/0x24c > [] sch_direct_xmit+0xb0/0x1a8 > [] __qdisc_run+0x214/0x2ec > [] __dev_queue_xmit+0x35c/0x5b4 > [] dev_queue_xmit+0x10/0x18 > [] register_vlan_dev+0xc74/0x10f8 [8021q] > [] dev_hard_start_xmit+0xa8/0x24c > [] __dev_queue_xmit+0x44c/0x5b4 > [] dev_queue_xmit+0x10/0x18 > [] neigh_connected_output+0xc0/0xe4 > [] ip_finish_output2+0x3c0/0x3fc > [] ip_finish_output+0xf8/0x1c4 > [] ip_mc_output+0x258/0x308 > [] ip_local_out+0x44/0x54 > [] ip_send_skb+0x1c/0xa8 > [] udp_send_skb+0x11c/0x244 > [] udp_sendmsg+0x534/0x6bc > [] inet_sendmsg+0x40/0xe0 > [] sock_sendmsg+0x3c/0x58 > [] ___sys_sendmsg+0x228/0x278 > [] __sys_sendmsg+0x58/0x98 > [] SyS_sendmsg+0x10/0x20 > Exception stack(0xffff000027dd3ec0 to 0xffff000027dd4000) > 3ec0: 0000000000000012 0000ffff8a7fdf18 0000000000004000 0000000000000000 > 3ee0: 0000ffff8a7ff258 0000ffff8a7ff150 0000ffff8a7ff840 0000000000000000 > 3f00: 00000000000000d3 0100010010000001 0000000003000001 0100050010000001 > 3f20: 0000000003000001 000409000c000000 0000000000000047 0000155107b31031 > 3f40: 0000ffff9b67dfb8 0000ffff9b90ddb0 0000000000000014 0000000000004000 > 3f60: 0000000000000012 0000ffff8a7fdf18 0000ffff780017b0 0000000000004000 > 3f80: 0000000000000010 0000000000000001 0000ffff8a7fdf00 0000ffff9000b770 > 3fa0: 0000000000000012 0000ffff8a7fde60 0000ffff9b90de10 0000ffff8a7fde60 > 3fc0: 0000ffff9b90de28 0000000080000000 0000000000000012 00000000000000d3 > 3fe0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > [] el0_svc_naked+0x34/0x38 > Code: d37d7c01 d37d7c02 f90037a1 f9445f01 (f822683b) > ---[ end trace eabda93d178d5bcb ]--- > Kernel panic - not syncing: Fatal exception in interrupt > SMP: stopping secondary CPUs > Kernel Offset: disabled > CPU features: 0x1802004 > Memory Limit: 6144 MB > -- cut -- > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Reviewed-by: Sergei Shtylyov > Signed-off-by: Dirk Behme [...] You must post this to netdev@vget.kernel.org, else the patch won't get applied, ever... MBR, Sergei