From: Marek Vasut <marek.vasut@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values
Date: Sat, 23 Mar 2019 02:28:08 +0100 [thread overview]
Message-ID: <b28f5e1d-b5fc-e88c-c8b5-21fc15aaceee@gmail.com> (raw)
In-Reply-To: <20190322084119.GI1005@kunai>
On 3/22/19 9:41 AM, Wolfram Sang wrote:
>
>> @@ -508,7 +509,7 @@ static void phy_write_reg(struct rcar_pcie *pcie,
>> unsigned int rate, unsigned int addr,
>> unsigned int lane, unsigned int data)
>
> What about converting 'addr' and 'data' here? Other than those, I didn't
> find other candidates in this driver.
Sure, fixed.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-03-23 1:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 2:38 [PATCH V2 1/6] PCI: rcar: Clean up remaining macros defining bits marek.vasut
2019-03-22 2:38 ` [PATCH V2 2/6] PCI: rcar: Replace unsigned long with u32 in register accessors marek.vasut
2019-03-22 8:20 ` Wolfram Sang
2019-03-22 2:38 ` [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values marek.vasut
2019-03-22 8:22 ` Wolfram Sang
2019-03-22 8:41 ` Wolfram Sang
2019-03-23 1:28 ` Marek Vasut [this message]
2019-03-22 2:38 ` [PATCH V2 4/6] PCI: rcar: Replace (8 * n) with (n << 3) marek.vasut
2019-03-22 8:32 ` Wolfram Sang
2019-03-22 2:38 ` [PATCH V2 5/6] PCI: rcar: Clean up debug messages marek.vasut
2019-03-22 8:32 ` Wolfram Sang
2019-03-22 2:38 ` [PATCH V2 6/6] PCI: rcar: Allow 64bit MSI addresses marek.vasut
2019-03-22 8:34 ` Wolfram Sang
2019-03-23 1:52 ` Marek Vasut
2019-03-22 8:20 ` [PATCH V2 1/6] PCI: rcar: Clean up remaining macros defining bits Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28f5e1d-b5fc-e88c-c8b5-21fc15aaceee@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).