From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9A3C10F0E for ; Wed, 10 Apr 2019 00:23:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A67520850 for ; Wed, 10 Apr 2019 00:23:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbfDJAXs (ORCPT ); Tue, 9 Apr 2019 20:23:48 -0400 Received: from www3345.sakura.ne.jp ([49.212.235.55]:47433 "EHLO www3345.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbfDJAXr (ORCPT ); Tue, 9 Apr 2019 20:23:47 -0400 Received: from fsav103.sakura.ne.jp (fsav103.sakura.ne.jp [27.133.134.230]) by www3345.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id x3A0Ncjb091622; Wed, 10 Apr 2019 09:23:38 +0900 (JST) (envelope-from cv-dong@jinso.co.jp) Received: from www3345.sakura.ne.jp (49.212.235.55) by fsav103.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav103.sakura.ne.jp); Wed, 10 Apr 2019 09:23:38 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav103.sakura.ne.jp) Received: from [192.168.1.225] (p14010-ipadfx41marunouchi.tokyo.ocn.ne.jp [61.118.107.10]) (authenticated bits=0) by www3345.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id x3A0NbeP091618 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NO); Wed, 10 Apr 2019 09:23:37 +0900 (JST) (envelope-from cv-dong@jinso.co.jp) Subject: Re: [PATCH 05/11] ARM: dts: r8a77470: Add VIN support To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= Cc: linux-renesas-soc@vger.kernel.org, broonie@kernel.org, geert+renesas@glider.be, horms+renesas@verge.net.au, devicetree@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com, kuninori.morimoto.gx@renesas.com, h-inayoshi@jinso.co.jp, nv-dung@jinso.co.jp, na-hoan@jinso.co.jp References: <1554799912-24764-1-git-send-email-cv-dong@jinso.co.jp> <1554799912-24764-6-git-send-email-cv-dong@jinso.co.jp> <20190409130138.GN15350@bigcity.dyn.berto.se> From: Cao Van Dong Message-ID: Date: Wed, 10 Apr 2019 09:23:37 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409130138.GN15350@bigcity.dyn.berto.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Dear Niklas-san, On 2019/04/09 22:01, Niklas Söderlund wrote: > Hi Cao, > > On 2019-04-09 17:51:46 +0900, Cao Van Dong wrote: >> Add vin{0|1} nodes to dtsi for VIN support on the RZ/G1C (r8a77470) SoC. >> >> Signed-off-by: Cao Van Dong >> --- >> arch/arm/boot/dts/r8a77470.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi >> index 3940a0d..e89c72f 100644 >> --- a/arch/arm/boot/dts/r8a77470.dtsi >> +++ b/arch/arm/boot/dts/r8a77470.dtsi >> @@ -780,6 +780,28 @@ >> status = "disabled"; >> }; >> >> + vin0: video@e6ef0000 { >> + compatible = "renesas,vin-r8a77470", >> + "renesas,rcar-gen2-vin"; > This patch looks good but you should also add renesas,vin-r8a77470 to > Documentation/devicetree/bindings/media/rcar_vin.txt in a separate > patch. > > Reviewed-by: Niklas Söderlund Thanks for your feedback! I will create a separate patch in version 2. Thank you, Dong >> + reg = <0 0xe6ef0000 0 0x1000>; >> + interrupts = ; >> + clocks = <&cpg CPG_MOD 811>; >> + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; >> + resets = <&cpg 811>; >> + status = "disabled"; >> + }; >> + >> + vin1: video@e6ef1000 { >> + compatible = "renesas,vin-r8a77470", >> + "renesas,rcar-gen2-vin"; >> + reg = <0 0xe6ef1000 0 0x1000>; >> + interrupts = ; >> + clocks = <&cpg CPG_MOD 810>; >> + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; >> + resets = <&cpg 810>; >> + status = "disabled"; >> + }; >> + >> sdhi0: sd@ee100000 { >> compatible = "renesas,sdhi-r8a77470", >> "renesas,rcar-gen2-sdhi"; >> -- >> 2.7.4 >>