From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3153BC4743C for ; Wed, 23 Jun 2021 16:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12997611C1 for ; Wed, 23 Jun 2021 16:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhFWQQH (ORCPT ); Wed, 23 Jun 2021 12:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhFWQQG (ORCPT ); Wed, 23 Jun 2021 12:16:06 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FC7EC061574 for ; Wed, 23 Jun 2021 09:13:49 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CCED09AA; Wed, 23 Jun 2021 18:13:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624464827; bh=+L1YwAvszWTaIUhE4X3mSmdnKlBeU5GR1USUOORxiTE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BDHCHIk53dP4VKGadVDsfYasnH1/YR3Si1PcMh84whVlZckGdSki9T081O1qhaQl5 Ce1kHUaBM45FSiv28RgeQ3SiEB/QMr0whtUeb4w0Pf5bIu/V+yOft2/TDycYEGzWGI 2y1XIfRA97uSXQsD1KLpL/l6NPWvY+W3TKIlWbu8= Subject: Re: [PATCH 0/2] arm64: dts: renesas: r8a779a0: Add INTC-EX support To: Geert Uytterhoeven , Yoshihiro Shimoda , Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org References: From: Kieran Bingham Message-ID: Date: Wed, 23 Jun 2021 17:13:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, On 23/06/2021 16:02, Geert Uytterhoeven wrote: > Hi all, > > This patch series adds support for the Interrupt Controller for External > Devices (INT-EC) in the Renesas R-Car V3U (r8a779a0) SoC. > > As there are two known issues, I'm posting this to a limited audience: > > 1. External interrupts have not been tested. > > Kieran: perhaps IRQ0 can be tested on Falcon with the MIPI DSI/eDP > bridge, by changing > > - interrupt-parent = <&gpio1>; > - interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&intc_ex>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > ? The "ti,sn65dsi86" driver doesn't seem to use interrupts, though, > so I don't know how feasible this is. I can add an interrupt handler if that's what you need, but I suspect that the change here simply 're-routes' the interrupt through the intc_ex so that it still needs an interrupt to be generated by the SN65DSI86? is that right? > Alternatively, with physical access, IRQ0 is available on test > point CP47, and IRQ2 on the GPIO CN. I do have physical access, so I can trigger this - Is there a suitable voltage or condition I can apply? (I.e. take a signal from a nearby pin to short it?) -- Kieran > 2. As recent revisions of R-Car Gen3 Hardware User's Manuals stopped > documenting module clocks for interrupt controllers, I don't know > which Module Stop bits control it. Hence I could not add the intc-ex > module clock to the R-Car V3U clock driver, but have used the CP > clock instead in DTS. Alternatively, as the driver doesn't really > use the clock (except implicitly through Runtime PM), we can drop > it, but that would need an update to the DT bindings. > > This series been boot-tested on a remote Falcon development board. > > Thanks for your comments! > > Geert Uytterhoeven (2): > dt-bindings: irqchip: renesas-irqc: Add R-Car V3U support > arm64: dts: renesas: r8a779a0: Add INTC-EX device node > > .../interrupt-controller/renesas,irqc.yaml | 1 + > arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 15 +++++++++++++++ > 2 files changed, 16 insertions(+) >