From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFCF2CCA479 for ; Thu, 7 Jul 2022 12:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235540AbiGGMhj (ORCPT ); Thu, 7 Jul 2022 08:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235557AbiGGMhb (ORCPT ); Thu, 7 Jul 2022 08:37:31 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C53426AF1 for ; Thu, 7 Jul 2022 05:37:27 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id j7so10563070wmp.2 for ; Thu, 07 Jul 2022 05:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IQSNyij1zzfzY4iwOOgBF0n7a6XIfStBbfb72/OYucI=; b=efCNUJMPLSymMwWjaWzvPl7cyHSzYiiCxLcVUroM89rxmrMk5+stBiVYUBOJKp5eGx F0DlVntaQbFZPeGx3WGUICBlRTYqvmIgVnmOWt5b6SVagJlFB39+qooBhnF2g5tCr4hl bLn13gA3Qfk1Jaw2433sYyqjvXNYz/dfLVnR0rclEtHtBrK2dnYs0OUd609Muf+DshE5 K3uKsRZ2VIlsBCYPKH5YVI9Ha1ZBv3mLiBJT2jdJPze0A8PCeZPp62Yfso2Nvm7tMO/z lho7889TJX2tWPpnZ8iDjOcVPP8QMQmcwfq01dmfWK5UaCwgVdDzlOIM7TiDxxrC3J8a lLMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IQSNyij1zzfzY4iwOOgBF0n7a6XIfStBbfb72/OYucI=; b=zs724ojEh9iLEoAOhuA+A7BcXXV3IlcpZdi0llf1LacM6I69b4RJyoqorm7wJTHRDD 2ohEdWE1F6oiFHlKXG0udgqm9GzWR7hOWU0fJaVNAsDli1lYRaXU0ZezNwvW71VEkCWm eQk/Pb6ggLXtlNUkrYWYTFwK5fbpFWYTMnfLLebkXSeL8boesk2jO5VolbrYkTRLqslD UMweQtLxEGL91ndV5W12kPIJwlOtOXZtk9ygIOc01InvjwISpMEL0StCCbCYvlBw9JZ0 Z7XcUrpy0gx8hZlqQEA+1l66H5X4GG65sArvL0ZPg85bpL9BpCy/GlsUIt1E9Qg7ptY/ qREA== X-Gm-Message-State: AJIora+X2M61jmLZ9qJ56n7zN6KvgZx958ZKrqrrZdGiqkQoCsesG1A4 X0QHofuuA1Vh8fJoZo0DaZKOiaklsv2xIA== X-Google-Smtp-Source: AGRyM1vVUGrRm3AF6K+6X9VD1A536tCyInsX+hOBlqrOrlQZABmjNKo9d4klcELHOV+qT0TRIgvJeA== X-Received: by 2002:a05:600c:1d85:b0:3a0:3d28:bdd9 with SMTP id p5-20020a05600c1d8500b003a03d28bdd9mr4494396wms.114.1657197445701; Thu, 07 Jul 2022 05:37:25 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id bn24-20020a056000061800b0020fe35aec4bsm37579172wrb.70.2022.07.07.05.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 05:37:25 -0700 (PDT) Message-ID: Date: Thu, 7 Jul 2022 14:37:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: Add support for hardware trip points Content-Language: en-US To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= Cc: Geert Uytterhoeven , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20210804091818.2196806-1-niklas.soderlund+renesas@ragnatech.se> <20210804091818.2196806-2-niklas.soderlund+renesas@ragnatech.se> <40b2b8d1-f86c-4788-767c-22e60283e458@linaro.org> <2605a591-abf9-01ca-015c-efc3978803b8@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 07/07/2022 12:26, Niklas Söderlund wrote: > Hi Daniel, > > On 2022-07-07 11:55:55 +0200, Daniel Lezcano wrote: > >> Thanks for double checking and confirming. I've a patch removing this code, >> no need to send one. I'll submit it along with other changes around this. >> Perhaps, I'll try a revert before, it would make more sense. > > Thanks. > > To be clear I don't think we should revert commit 47cf09e0f4fc5120 > ("thermal/drivers/rcar_gen3_thermal: Add support for hardware trip > points"). Only remove the 4 lines it adds to rcar_gen3_thermal_resume() > as they are redundant. Does this match your view of the revert? Yes >> Do you think the 'revert' should be backported ? > > I have no strong opinion, I think it's a matter of risk :-) > > There is no real harm in writing the trip points to hardware twice > during resume. On the other hand if we *know* the thermal core in the > backported kernel will always call set_trips() after the device is > resumed, then there is no harm in removing it. Yes, I agree. Thanks for your feedback -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog